1212691 - Vagrant fails puppet when importing data

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Mossop was setting up a dev environment from scratch and hit this:

==> default: Running Puppet with vagrant.pp...
==> default: notice: /Stage[main]/Init/Group[puppet]/ensure: created
==> default: notice: /Stage[main]/Mysql/Package[mysql-server]/ensure: created
==> default: notice: /Stage[main]/Dev/File[/home/vagrant]/mode: mode changed '700' to '755'
==> default: notice: /Stage[main]/Mysql/Service[mysqld]/ensure: ensure changed 'stopped' to 'running'
==> default: notice: /Stage[main]/Mysql/Package[mysql-devel]/ensure: created
==> default: notice: /Stage[main]/Python/Package[mod_wsgi]/ensure: created
==> default: notice: /Stage[main]/Python/Package[python-setuptools]/ensure: created
==> default: notice: /Stage[main]/Python/Package[python-devel]/ensure: created
==> default: notice: /Stage[main]/Python/Exec[pip-install]/returns: executed successfully
==> default: notice: /Stage[main]/Python/Exec[pip-install-compiled]/returns: executed successfully
==> default: notice: /Stage[main]/Apache/File[/var/log/httpd/balrog.mozilla.dev]/ensure: created
==> default: notice: /Stage[main]/Apache/Package[httpd-devel]/ensure: created
==> default: notice: /Stage[main]/Apache/File[/etc/httpd/conf.d/balrog.conf]/ensure: defined content as '{md5}8eb42584b2ab9c9f84e99c7b48e87cdd'
==> default: notice: /Stage[main]/Apache/Service[httpd]/ensure: ensure changed 'stopped' to 'running'
==> default: notice: /Stage[main]/Apache/File[/var/log/httpd/balrog-admin.mozilla.dev]/ensure: created
==> default: notice: /Stage[main]/Balrog/File[/etc/aus]/ensure: created
==> default: notice: /Stage[main]/Balrog/File[/var/log/aus.log]/ensure: created
==> default: notice: /Stage[main]/Balrog/File[/var/log/auscef.log]/ensure: created
==> default: notice: /Stage[main]/Balrog/Exec[create_mysql_database]/returns: executed successfully
==> default: notice: /Stage[main]/Balrog/Exec[grant_ro_mysql_database]/returns: executed successfully
==> default: notice: /Stage[main]/Balrog/Exec[grant_mysql_database]/returns: executed successfully
==> default: notice: /Stage[main]/Balrog/Exec[create_tables]/returns: executed successfully
==> default: err: /Stage[main]/Balrog/Exec[import_sample_data]/returns: change from notrun to 0 failed: /bin/cat /home/vagrant/project/puppet/files/sample-data.sql | mysql -uroot -D balrog && touch /home/vagrant/import-done returned 1 instead of one of [0] at /tmp/vagrant-puppet/manifests-846018e2aa141a5eb79a64b4015fc5f3/classes/balrog.pp:61
==> default: notice: /Stage[main]/Balrog/File[/var/log/ausadmin.log]/ensure: created
==> default: notice: Finished catalog run in 73.64 seconds

It may be related to the last line of sample-data.sql:
INSERT INTO `rules` VALUES (1,100,'Firefox-mozilla-central-nightly-latest',100,'minor','Firefox',NULL,'nightly',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,1),(2,100,'Firefox-mozilla-aurora-nightly-latest',100,'minor','Firefox',NULL,'aurora',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,1);

The recent work on the whitelist (bug 1201538) may have missed this file.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

https://github.com/mozilla/balrog/commit/5eb08fb879b7b068e5f66f20f4ab9d9675ca8bba#diff-5d99ded88f9aa45a1c96615ebebf3ac3 should have fixed this.