1212701 - Remove AbstractMediaDecoder::OnDecodeTaskQueue()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/mozilla-central/file/a45d680f073f/dom/media/webm/WebMReader.cpp#l285

Since bug 1148234 is completed, we can assert OnTaskQueue() and remove OnDecodeTaskQueue() functions.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8209bc97376d

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a11308ec63d3

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1212701. Part 1 - remove AbstractMediaDecoder::OnDecodeTaskQueue().

Bug 1212701. Part 1 - remove AbstractMediaDecoder::OnDecodeTaskQueue().

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1212701. Part 2 - remove MediaDecoderStateMachine::OnDecodeTaskQueue() which is unused.

Bug 1212701. Part 2 - remove MediaDecoderStateMachine::OnDecodeTaskQueue() which is unused.

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8672435 [details]
MozReview Request: Bug 1212701. Part 1 - remove AbstractMediaDecoder::OnDecodeTaskQueue().

https://reviewboard.mozilla.org/r/21711/#review19507

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8672436 [details]
MozReview Request: Bug 1212701. Part 2 - remove MediaDecoderStateMachine::OnDecodeTaskQueue() which is unused.

https://reviewboard.mozilla.org/r/21713/#review19509

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f532f8439be
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d1a08a0ba44

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2f532f8439be
https://hg.mozilla.org/mozilla-central/rev/7d1a08a0ba44