1212703 - [Simulator] Should add TVSimulatorService stuff to package-manifest.in

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Simulator, defect)

Description

[Mantaroh Yoshinaga[:mantaroh]]

In bug 1180589, We added the TVSimulatorService XPCOM.
However there aren't existing the define in b2g/package-manifest file.

Comment 1

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: WIP_bug1212703.patch

Comment 2

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: bug1212703.patch

Hi sean,

I added the TVSimulatorService XPCOM.
However there aren't define in the b2g/installer/package-manifest.in[1]

In debug build, it work fine.
But packaged XPI not include this xpcom.

Comment 3

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: bug1212703.patch

Hi Sean,
Sorry,
Previous patch includes unnecessary part(mftb/tests/TestTuple.cpp).

Comment 4

[Evelyn Hung]

Hi Mantaroh,
After applying this patch, I still can't see mock channel data in my Simulator build. Is there anything we need in Gaia?

Comment 5

[Evelyn Hung]

(In reply to Evelyn Hung [:evelyn] from comment #4)
> Hi Mantaroh,
> After applying this patch, I still can't see mock channel data in my
> Simulator build. Is there anything we need in Gaia?

so this is another bug, not related to this one..
Mantaroh, could we check-in the patch here? it's already r+. Thanks.

Comment 6

[Mantaroh Yoshinaga[:mantaroh]]

Sorry.
I forgot add checkin-needed.
Thank you.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/f45115d073e0

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f45115d073e0