Closed Bug 1212703 Opened 9 years ago Closed 9 years ago

[Simulator] Should add TVSimulatorService stuff to package-manifest.in

Categories

(Firefox OS Graveyard :: Simulator, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
FxOS-S9 (16Oct)
Tracking Status
firefox44 --- fixed

People

(Reporter: mantaroh, Assigned: mantaroh)

References

Details

Attachments

(1 file, 2 obsolete files)

In bug 1180589, We added the TVSimulatorService XPCOM.
However there aren't existing the define in b2g/package-manifest file.
Attached patch WIP_bug1212703.patch (obsolete) — Splinter Review
Attached patch bug1212703.patch (obsolete) — Splinter Review
Hi sean,

I added the TVSimulatorService XPCOM.
However there aren't define in the b2g/installer/package-manifest.in[1]

In debug build, it work fine.
But packaged XPI not include this xpcom.
Attachment #8671145 - Attachment is obsolete: true
Attachment #8671746 - Flags: review?(selin)
Attached patch bug1212703.patchSplinter Review
Hi Sean,
Sorry,
Previous patch includes unnecessary part(mftb/tests/TestTuple.cpp).
Attachment #8671746 - Attachment is obsolete: true
Attachment #8671746 - Flags: review?(selin)
Attachment #8671754 - Flags: review?(selin)
Attachment #8671754 - Flags: review?(selin) → review+
Blocks: 1180124
No longer depends on: 1180124
Blocks: 1201451
Hi Mantaroh,
After applying this patch, I still can't see mock channel data in my Simulator build. Is there anything we need in Gaia?
(In reply to Evelyn Hung [:evelyn] from comment #4)
> Hi Mantaroh,
> After applying this patch, I still can't see mock channel data in my
> Simulator build. Is there anything we need in Gaia?

so this is another bug, not related to this one..
Mantaroh, could we check-in the patch here? it's already r+. Thanks.
Flags: needinfo?(mantaroh)
Sorry.
I forgot add checkin-needed.
Thank you.
Status: NEW → ASSIGNED
Flags: needinfo?(mantaroh)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f45115d073e0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S9 (16Oct)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: