Closed
Bug 1212703
Opened 9 years ago
Closed 9 years ago
[Simulator] Should add TVSimulatorService stuff to package-manifest.in
Categories
(Firefox OS Graveyard :: Simulator, defect)
Tracking
(firefox44 fixed)
RESOLVED
FIXED
FxOS-S9 (16Oct)
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: mantaroh, Assigned: mantaroh)
References
Details
Attachments
(1 file, 2 obsolete files)
1.07 KB,
patch
|
selin
:
review+
|
Details | Diff | Splinter Review |
In bug 1180589, We added the TVSimulatorService XPCOM. However there aren't existing the define in b2g/package-manifest file.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Hi sean, I added the TVSimulatorService XPCOM. However there aren't define in the b2g/installer/package-manifest.in[1] In debug build, it work fine. But packaged XPI not include this xpcom.
Attachment #8671145 -
Attachment is obsolete: true
Attachment #8671746 -
Flags: review?(selin)
Assignee | ||
Comment 3•9 years ago
|
||
Hi Sean, Sorry, Previous patch includes unnecessary part(mftb/tests/TestTuple.cpp).
Attachment #8671746 -
Attachment is obsolete: true
Attachment #8671746 -
Flags: review?(selin)
Attachment #8671754 -
Flags: review?(selin)
Updated•9 years ago
|
Attachment #8671754 -
Flags: review?(selin) → review+
Updated•9 years ago
|
Comment 4•9 years ago
|
||
Hi Mantaroh, After applying this patch, I still can't see mock channel data in my Simulator build. Is there anything we need in Gaia?
Comment 5•9 years ago
|
||
(In reply to Evelyn Hung [:evelyn] from comment #4) > Hi Mantaroh, > After applying this patch, I still can't see mock channel data in my > Simulator build. Is there anything we need in Gaia? so this is another bug, not related to this one.. Mantaroh, could we check-in the patch here? it's already r+. Thanks.
Flags: needinfo?(mantaroh)
Assignee | ||
Comment 6•9 years ago
|
||
Sorry. I forgot add checkin-needed. Thank you.
https://hg.mozilla.org/mozilla-central/rev/f45115d073e0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S9 (16Oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•