Closed Bug 1212712 Opened 8 years ago Closed 8 years ago
Factor generated emails and bugzilla comments should use HTTPS links
(Tree Management Graveyard :: OrangeFactor, defect)
(Reporter: MattN, Assigned: MattN)
2.22 KB, patch
|Details | Diff | Splinter Review|
Unless there is a good reason, we shouldn't be using (or even hosting) content over HTTP. This replaces HTTP references to Orangefactor with HTTPS. We will also need to change woo_cron.conf on the server.
Attachment #8671157 - Flags: review?(emorley)
8 years ago
Comment on attachment 8671157 [details] [diff] [review] v.1 patch Yeah I agree HTTPS should be used everywhere. The reason for HTTP links in the new bug comments is that the existing weekly email used them too - and the last time I tried using OrangeFactor over HTTPS (some months ago) it didn't work for some reasons (I can't remember what, but possible cert issues). However it seems to work now, so let's switch. Brasstacks is a legacy server, and OrangeFactor (v1) is effectively EOL, so this will all go away once a replacement for OrangeFactor is written that uses Treeherder's APIs directly (likely hosted on the Treeherder infra).
Attachment #8671157 - Flags: review?(emorley) → review+
8 years ago
remote: https://hg.mozilla.org/automation/orangefactor/rev/fa035a8d208e Deployed: [firstname.lastname@example.org ~]# su - webtools [email@example.com ~]$ cd ~/apps/orangefactor/src/orangefactor [firstname.lastname@example.org orangefactor]$ hg pull -uv pulling from http://hg.mozilla.org/automation/orangefactor/ searching for changes all local heads known remotely adding changesets adding manifests adding file changes added 1 changesets with 3 changes to 3 files resolving manifests getting html/scripts/woo.config.js getting templates/bug_comment.template getting woo_cron.conf.example 3 files updated, 0 files merged, 0 files removed, 0 files unresolved [email@example.com orangefactor]$ vi woo_cron.conf [firstname.lastname@example.org orangefactor]$ grep external_server_url woo_cron.conf external_server_url = https://brasstacks.mozilla.com/orangefactor [email@example.com orangefactor]$ logout [firstname.lastname@example.org ~]# cd /home/webtools/apps/orangefactor/src/orangefactor/ && ./deploy.sh [email@example.com orangefactor]# Thanks for the patch :-)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Summary: Orangefactor periodic bugzilla comments should use HTTPS links → OrangeFactor generated emails and bugzilla comments should use HTTPS links
3 years ago
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.