Closed Bug 1212712 Opened 9 years ago Closed 9 years ago

OrangeFactor generated emails and bugzilla comments should use HTTPS links

Categories

(Tree Management Graveyard :: OrangeFactor, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: MattN, Assigned: MattN)

References

Details

Attachments

(1 file)

Attached patch v.1 patchSplinter Review
Unless there is a good reason, we shouldn't be using (or even hosting) content over HTTP. This replaces HTTP references to Orangefactor with HTTPS.

We will also need to change woo_cron.conf on the server.
Attachment #8671157 - Flags: review?(emorley)
Comment on attachment 8671157 [details] [diff] [review]
v.1 patch

Yeah I agree HTTPS should be used everywhere. The reason for HTTP links in the new bug comments is that the existing weekly email used them too - and the last time I tried using OrangeFactor over HTTPS (some months ago) it didn't work for some reasons (I can't remember what, but possible cert issues).

However it seems to work now, so let's switch.

Brasstacks is a legacy server, and OrangeFactor (v1) is effectively EOL, so this will all go away once a replacement for OrangeFactor is written that uses Treeherder's APIs directly (likely hosted on the Treeherder infra).
Attachment #8671157 - Flags: review?(emorley) → review+
remote:   https://hg.mozilla.org/automation/orangefactor/rev/fa035a8d208e

Deployed:

[root@brasstacks1.dmz.scl3 ~]# su - webtools
[webtools@brasstacks1.dmz.scl3 ~]$ cd ~/apps/orangefactor/src/orangefactor
[webtools@brasstacks1.dmz.scl3 orangefactor]$ hg pull -uv
pulling from http://hg.mozilla.org/automation/orangefactor/
searching for changes
all local heads known remotely
adding changesets
adding manifests
adding file changes
added 1 changesets with 3 changes to 3 files
resolving manifests
getting html/scripts/woo.config.js
getting templates/bug_comment.template
getting woo_cron.conf.example
3 files updated, 0 files merged, 0 files removed, 0 files unresolved
[webtools@brasstacks1.dmz.scl3 orangefactor]$ vi woo_cron.conf
[webtools@brasstacks1.dmz.scl3 orangefactor]$ grep external_server_url woo_cron.conf
external_server_url = https://brasstacks.mozilla.com/orangefactor
[webtools@brasstacks1.dmz.scl3 orangefactor]$ logout
[root@brasstacks1.dmz.scl3 ~]# cd /home/webtools/apps/orangefactor/src/orangefactor/ && ./deploy.sh
[root@brasstacks1.dmz.scl3 orangefactor]#

Thanks for the patch :-)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Summary: Orangefactor periodic bugzilla comments should use HTTPS links → OrangeFactor generated emails and bugzilla comments should use HTTPS links
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: