Closed Bug 1212726 Opened 6 years ago Closed 6 years ago

SpatialNavigator should check if an element is navigable before focusing it.

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: lchang, Assigned: lchang)

References

Details

(Whiteboard: [partner-cherry-picked<2015/11/10>])

Attachments

(2 files, 1 obsolete file)

SpatialNavigator should check whether an element is navigable before trying to traverse, move and focus it.
Comment on attachment 8671175 [details] [review]
[gaia] luke-chang:1212726_spatialnavigator_check_navigable > mozilla-b2g:master

Hi Evelyn,

Please take a look at this patch. Thanks.
Attachment #8671175 - Flags: review?(ehung)
Comment on attachment 8671175 [details] [review]
[gaia] luke-chang:1212726_spatialnavigator_check_navigable > mozilla-b2g:master

Good job!
Attachment #8671175 - Flags: review?(ehung) → review+
tests passed: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=2aeab264eaa7bc503b7d499e39881299b64944b6

landed on master: https://github.com/mozilla-b2g/gaia/commit/40f71f6242f7f2411cb3196d30a53af833fc52a6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [partner-cherry-pick]
backout: https://github.com/mozilla-b2g/gaia/commit/7053599752eaea45c0a03d99daeea490c4a2bc2a

Found a minor bug so revert it. Will land it again later.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8671413 - Attachment is obsolete: true
tests passed: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=d9f65dba529d35e364b0bd536f9020a92802cd27

landed on master (again): https://github.com/mozilla-b2g/gaia/commit/1341c372eca9034fa2342d9ee9b52975c80c07e2
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [partner-cherry-pick] → [partner-cherry-picked<2015/11/10>]
You need to log in before you can comment on or make changes to this bug.