1212728 - Update yahoo-jp.xml Yahoo! Japan search plugin to replace with Param

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Makoto Kato [:m_kato]]

By bug 1200170, affiliate code is moved to param instead of MozParam since MozParam doesn't support some platform such Firefox Android.

So iOS has same issue, so we should pick up from Firefox Android.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1137

pick up the latest search plugin from bug 1200170.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8671180 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1137

The change looks safe, but I have no idea if it's what we want. mconnor?

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8671180 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1137

mconnor seems to be incommunicado. Mark, do you know if this is good to land for iOS?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8671180 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1137

I am pretty sure the Fx iOS does not support MozParam and that we don't use iOS specific Yahoo params, so this should be fine to land.

Normally, I'd ask if Yahoo JP is different than Yahoo, but the same change was made on Android, so I think this is safe.

Comment 5

[Richard Newman [:rnewman]]

Rebased and landed.

ed96246