Closed Bug 1212742 Opened 9 years ago Closed 9 years ago

[Browser] No lock icon shows on URL bar when open a secure website which application-name is defined blank

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.5+)

VERIFIED FIXED
blocking-b2g 2.5+

People

(Reporter: ashiue, Assigned: apastor)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

Attached image no_lock_icon_shows.png
STR:
1. Open https://www.verisign.com/ which application-name is defined blank <meta name="application-name" content=" " />

Expected result:
1. A lock icon shows on URL bar to indicate this site is in SSL state

Actual result:
1. No lock icon shows on URL bar


[Flame]
Build ID           	20151007150205
Gaia Revision      	b99837aa2294348317bcae68acabe71d9a83d774
Gaia Date          	2015-10-07 13:04:16
Gecko Revision     	https://hg.mozilla.org/mozilla-central/rev/1e1fa696e2b626ead6817b7c5bd871fec5d5ab5a
Gecko Version      	44.0a1
Device Name        	flame
Firmware(Release)  	4.4.2
Firmware(Incremental)  eng.cltbld.20151007.183338
Firmware Date      	Wed Oct  7 18:33:51 EDT 2015
Bootloader         	L1TC000118D0

[Aries]
Build ID           	20151008002716
Gaia Revision      	b99837aa2294348317bcae68acabe71d9a83d774
Gaia Date          	2015-10-07 13:04:16
Gecko Revision     	https://hg.mozilla.org/mozilla-central/rev/c6ede6f30f3dc886543bb1c76fd7c8b5a151786b
Gecko Version      	44.0a1
Device Name        	aries
Firmware(Release)  	4.4.2
Firmware(Incremental)  eng.worker.20151007.234555
Firmware Date      	Wed Oct  7 23:46:03 UTC 2015
Bootloader         	s1
QA Whiteboard: [COM=Pin the Web]
Whiteboard: [systemsfe]
blocking-b2g: --- → 2.5+
Assignee: nobody → apastor
Comment on attachment 8671442 [details] [review]
[gaia] albertopq:1212742-lock-icon > mozilla-b2g:master

Quick review? Thanks!
Attachment #8671442 - Flags: review?(mhenretty)
Comment on attachment 8671442 [details] [review]
[gaia] albertopq:1212742-lock-icon > mozilla-b2g:master

With the patch applied, I'm still not seeing either the lock icon, or anything in the URL bar at all. We should probably fallback to the URL when application name is blank. I tried both make install and make reset, so I think this bug still exists with the patch.
Attachment #8671442 - Flags: review?(mhenretty)
Priority: -- → P2
Comment on attachment 8671442 [details] [review]
[gaia] albertopq:1212742-lock-icon > mozilla-b2g:master

That's weird. It does work for me in both Aries and Flame. Anyway, you are right that we shouldn't update the name if is empty, so added it to the PR.
Attachment #8671442 - Flags: review?(mhenretty)
Comment on attachment 8671442 [details] [review]
[gaia] albertopq:1212742-lock-icon > mozilla-b2g:master

LGTM, thank you for fixing the other bug too and for the test.
Attachment #8671442 - Flags: review?(mhenretty) → review+
master:https://github.com/mozilla-b2g/gaia/commit/836ca207dabd9643503ac145e6a8391da6b43b46
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified on

[Flame]
Build ID               20151014150203
Gaia Revision          c64d6e345aa477f2a24b676e84a47020a00d015d
Gaia Date              2015-10-14 15:54:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4f4615ffec6a6a7ec40ff61ffda90a46c53f8d31
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151014.183316
Firmware Date          Wed Oct 14 18:33:28 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151014225836
Gaia Revision          c64d6e345aa477f2a24b676e84a47020a00d015d
Gaia Date              2015-10-14 15:54:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4f4615ffec6a6a7ec40ff61ffda90a46c53f8d31
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151014.221548
Firmware Date          Wed Oct 14 22:15:56 UTC 2015
Bootloader             s1
Status: RESOLVED → VERIFIED
Flags: in-moztrap+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: