1212767 - Use .properties for the CSS summary tables in en-US pages

Status: RESOLVED FIXED

(Developer Documentation Graveyard :: CSS, enhancement)

Description

[Jean-Yves Perrier [:teoli]]

(see bug 1207344#c6).

.cssprop: 309 (will be much less when all pages using the {{cssinfo}} macro got refreshed)
https://developer.mozilla.org/en-US/search?css_classnames=cssprop

We need to update the pages using {{cssinfo}} and to convert the remaining ones

Comment 1

[Sebastian Zartner [:sebo]]

After updating all pages using {{cssinfo}} there are just ~40 pages left.

Should browser-specific properties like '-moz-outline-radius' also be stored the CSS DB? If not, we need to create the table manually or use the 'propertiesbox' template.

Sebastian

Comment 2

[Florian Scholz (Open Web Docs)]

Kuma's UI test suite likely needs to be updated, too.
https://github.com/mozilla/kuma/blob/master/tests/ui/tests/fixtures/in-content.html

(This one creates pages like https://developer.mozilla.org/en-US/docs/Intern_Test_1443623174424 etc.)

Comment 3

[Jean-Yves Perrier [:teoli]]

(In reply to Sebastian Zartner [:sebo] from comment #1)
> Should browser-specific properties like '-moz-outline-radius' also be stored
> the CSS DB? If not, we need to create the table manually or use the
> 'propertiesbox' template.
> 

I think we should add them in the CSS DB, there aren't that many of them, and when they become standard (which is a trend), we "just" have to rename them.

There shouldn't be too many of them, though they are very old.

(wondering if we should list properties alphabetically (without taking into account prefixed) in CSSData)

Comment 4

[Sebastian Zartner [:sebo]]

(In reply to Jean-Yves Perrier [:teoli] from comment #3)
> (In reply to Sebastian Zartner [:sebo] from comment #1)
> > Should browser-specific properties like '-moz-outline-radius' also be stored
> > the CSS DB? If not, we need to create the table manually or use the
> > 'propertiesbox' template.
> > 
> 
> I think we should add them in the CSS DB, there aren't that many of them,
> and when they become standard (which is a trend), we "just" have to rename
> them.
> 
> There shouldn't be too many of them, though they are very old.

Good, so I'll do that.

> (wondering if we should list properties alphabetically (without taking into
> account prefixed) in CSSData)

I split that out into bug 1213807.

Sebastian

Comment 5

[Sebastian Zartner [:sebo]]

(In reply to Florian Scholz [:fscholz] (MDN) from comment #2)
> Kuma's UI test suite likely needs to be updated, too.
> https://github.com/mozilla/kuma/blob/master/tests/ui/tests/fixtures/in-
> content.html
> 
> (This one creates pages like
> https://developer.mozilla.org/en-US/docs/Intern_Test_1443623174424 etc.)

I've updated the the existing ones manually now. Are those pages meant to stay in the wiki after the tests are finished?

Sebastian

Comment 6

[Florian Scholz (Open Web Docs)]

No, I think they should be removed. Needinfo'ing David for input. Can we update the test to use the ".properties" class and is it possible that you (automatically) delete the pages again from prod once run successfully ?

Comment 7

[David Walsh :davidwalsh]

Pull request to update the className here:

https://github.com/mozilla/kuma/pull/3565

As for automated deletion, I've not coded that.  These "destructive" tests wont be run on prod in the future so more of those pages shouldn't be added.  Once we have the automated tests completed, I'll go in and erase these pages.  You can erase then now if you'd like!

Comment 8

[Jean-Yves Perrier [:teoli]]

Nice! I erase the pages periodically (keeping a few of the recent ones). Just file a bug to erase the remaining ones once the automated tests are on and assigned it to me.

Comment 9

[Sebastian Zartner [:sebo]]

Fixed all English pages now. The remaining ones listed when doing the search are redirects and therefore related to bug 1213733.

Though we still have ~580 pages[1] when not filtering for English. I assume they should *not* be part of this issue. Do you agree, Jean-Yves? If so, we can call this bug done.

Sebastian

[1] https://developer.mozilla.org/en-US/search?locale=*&css_classnames=cssprop

Comment 10

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/c40696fdea7a2f1a9ab7f7528f36ef8b05f115ba
bug 1212767 - Update test fixture CSS class

https://github.com/mozilla/kuma/commit/400f49c55d1d2c905d3236b44eb201c1793c1df0
Merge pull request #3565 from mozilla/1212767-properties-intern

bug 1212767 - Update test fixture CSS class

Comment 11

[Sebastian Zartner [:sebo]]

As of bug 1212755 comment 7 this issue is done.

Sebastian