1212784 - Do not screenshot the homescreen when an app is launched

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[vnicolas]

Attachment: do.not.screenshot.homescreen.patch

I know there are plans to show the homescreen in the card view one day. But so far it is not displayed there and the system app keeps creating a screenshot which ends up competing for resources (memory and cpu) during app launch.

The proposed patch removed the screenshot. I believe that once we want to have the homescreen visible in the card view we should use our new ability to keep layer tree alive instead of forcing a screenshot. This may need a few platform tweaks but that should be much more efficient.

Comment 1

[vnicolas]

Attachment: no.screenshot.for.homescreen.patch

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 8672559 [details] [diff] [review]
no.screenshot.for.homescreen.patch

Review of attachment 8672559 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed :)

::: apps/system/js/app_window.js
@@ +2107,5 @@
>      this._hideScreenshotOverlay();
>    };
>  
>    AppWindow.prototype._handle__closed = function aw_closed() {
> +    if (!this.loaded || this.isHomescreen ||

When there's no inline activities, |this.getBottomMostWindow() == this|
so we can simplify the condifition to |!this.loaded || this.getBottomMostWindow().isHomescreen|

Comment 3

[vnicolas]

Oh right. This is purely my bad. I thought it was not working as you said, because the test was failing when I did that. But finally it was my bad, I set |app1.rearWindow = app2| in the test...

Comment 4

[vnicolas]

Attachment: no.screenshot.for.homescreen.patch

Update patch for check-in.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] vingtetun:no.screenshot.for.homescreen > mozilla-b2g:master

Comment 6

[vnicolas]

Comment on attachment 8672579 [details] [diff] [review]
no.screenshot.for.homescreen.patch

Carrying, r+.

Comment 7

[vnicolas]

Comment on attachment 8678848 [details] [review]
[gaia] vingtetun:no.screenshot.for.homescreen > mozilla-b2g:master

I mean carrying r+ here...

Comment 8

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/7a5992c5e3a31cd2eeb8610192228f79cbe8111e