121282 - Pressing enter causes caret to jump from end of <p> to the<h1>

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[TucsonTester1]

build: 2002011703
platform: Windows XP
ability to reproduce: always

Steps to reproduce:

1. open a blank composer document
2. choose "paragraph" from the format drop-down list and type in some text
("paragraph").
3. hit enter
4. choose "heading 1" from the format drop-down list and type in some text
("heading 1").
5. move cursor back to the end of the "paragraph" text.
6. hit enter once.

results: cursor moves to the beginning of the "heading 1" line
expected results: it would put a blank line in between the "paragraph" and the
"heading 1"

more results:

1. after noticing that cursor moves to "heading 1" line, then move cursor back
to the end of the "paragraph" line.
2. press enter several times repeatedly.

Notice how the composer finally inserts a line, but then deletes it and the
process goes back and forth as you press the enter key repeatedly.  It's very
bizarre.

Comment 1

[Oliver Klee]

Confirming on 2002011503 Win2k.

Comment 2

[Kathleen :Brade]

Could you please clarify step 5: is this done by clicking at the end of the line
or by pressing an arrow key or ?

Sounds like a Core bug...
nominate for EDITORBASE consideration

Comment 3

[TucsonTester1]

The way I did it originally (step 5) was by clicking at the end of "paragraph"
with the mouse pointer.  I did try it the other way by using the "up" arrow key
to move it back to the previous line and I still got the same results.

Comment 4

[Kevin McCluskey (gone)]

Marking EDITORBASE+.

Comment 5

[Joe Francis]

Attachment: Diffs of nsHTMLEditRules.cpp

I have a ton of patches to this file.  I hand editted the diff here to be just
the relavant ones for this bug, but the line numbers may not match up.	

However the diff is simple: I'm just changing some IsBreak() calls to
IsVisBreak() instead.  This bug is caused by non-visible breaks fooling the
editor code into splitting the <p> when instead it should insert a <br>.

Comment 6

[Joe Francis]

099

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 67683 [details] [diff] [review]
Diffs of nsHTMLEditRules.cpp

r=glazman

Comment 8

[kinmoz]

Comment on attachment 67683 [details] [diff] [review]
Diffs of nsHTMLEditRules.cpp

sr=[e-mail]

Comment 9

[Joe Francis]

fix landed on trunk

Comment 10

[michael wendell]

Looks good on build 2002021108.

Marking Verified.