Closed Bug 1212845 Opened 9 years ago Closed 9 years ago

Cannot build FOTA without FOTA_DEVICE_DATA_FILES

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Keywords: regression)

Attachments

(1 file)

43 bytes, text/x-github-pull-request
gsvelto
: review+
Details | Review
Traceback (most recent call last):
  File "tools/update-tools/build-flash-fota.py", line 130, in <module>
    main()
  File "tools/update-tools/build-flash-fota.py", line 124, in main
    build_flash_fota(parser.parse_args())
  File "tools/update-tools/build-flash-fota.py", line 56, in build_flash_fota
    output_zip, update_bin)
  File "/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G.L/tools/update-tools/update_tools.py", line 1215, in build_flash_fota
    flash_zip.write_updater_script(self.build_flash_script())
  File "/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G.L/tools/update-tools/update_tools.py", line 1338, in build_flash_script
    self.CleanDeviceFiles()
  File "/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G.L/tools/update-tools/update_tools.py", line 1075, in CleanDeviceFiles
    deviceCleanup = filter(lambda x: len(x) > 0, os.environ.get("FOTA_DEVICE_DATA_FILES").split(" "))
AttributeError: 'NoneType' object has no attribute 'split'
Attached file B2G PR
Attachment #8671360 - Flags: review?(gsvelto)
Comment on attachment 8671360 [details] [review]
B2G PR

LGTM, thanks.
Attachment #8671360 - Flags: review?(gsvelto) → review+
https://github.com/mozilla-b2g/B2G/commit/da17fd0a5402504c8b0f59b5a196c6116517394c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: