1212856 - Upgrade bugsy to v0.6.0

Status: RESOLVED FIXED

(Developer Services :: General, task)

Description

[David Burns :automatedtester]

The handling of erros has been dramatically changed and can handle most errors from Bugzilla.

Comment 1

[David Burns :automatedtester]

Attachment: MozReview Request: Upgrade Bugsy to v0.6.0 (Bug 1212856) r?gps

Upgrade Bugsy to v0.6.0 (Bug 1212856) r?gps

Changelog:
 * Update flake8 config to only check the correct items.
 * Fix flake8 errors.
 * Move final requests to use central request and handler methods
 * Add more tests for resiliency against HTTP errors during API requests
 * Remove support for Python 2.6. I won't be actively working against it
   but won't be mindful of errors
 * Update error handling for the majority of cases so that it is handled centrally
 * Clean up imports of tests
 * Remove duplication in Exception handling
 * Move Errors to their own file and update imports for others.
 * Move JSON handling into request method
 * Use correct response HTTP code for Bugzilla error handling tests

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8671575 [details]
MozReview Request: Upgrade Bugsy to v0.6.0 (Bug 1212856) r?gps

https://reviewboard.mozilla.org/r/21595/#review19443

I, sadly, can't r+ this yet because apparently some of the API changes broke things.

  AttributeError: 'dict' object has no attribute 'json'
    File "/Users/gps/src/hgcustom/version-control-tools/testing/vcttesting/bugzilla/mach_commands.py", line 111, in dump_bug
      print(self.b.serialize_bugs(bugs))
    File "/Users/gps/src/hgcustom/version-control-tools/testing/vcttesting/bugzilla/__init__.py", line 162, in serialize_bugs
      r = self.client.request('bug/%s/comment' % bid).json()

This /might/ be the only issue. But there were a pile of errors because of it and I'm not sure if other issues are lingering.

Comment 3

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/21595/#review19445

Since I have a test environment, I can probably look into this for you. Looks like a trivial fix.

Comment 4

[David Burns :automatedtester]

Comment on attachment 8671575 [details]
MozReview Request: Upgrade Bugsy to v0.6.0 (Bug 1212856) r?gps

Upgrade Bugsy to v0.6.0 (Bug 1212856) r?gps

Changelog:
 * Update flake8 config to only check the correct items.
 * Fix flake8 errors.
 * Move final requests to use central request and handler methods
 * Add more tests for resiliency against HTTP errors during API requests
 * Remove support for Python 2.6. I won't be actively working against it
   but won't be mindful of errors
 * Update error handling for the majority of cases so that it is handled centrally
 * Clean up imports of tests
 * Remove duplication in Exception handling
 * Move Errors to their own file and update imports for others.
 * Move JSON handling into request method
 * Use correct response HTTP code for Bugzilla error handling tests

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8671575 [details]
MozReview Request: Upgrade Bugsy to v0.6.0 (Bug 1212856) r?gps

https://reviewboard.mozilla.org/r/21595/#review19479

::: testing/vcttesting/bugzilla/__init__.py:177
(Diff revision 2)
>              r = self.client.request('bug/%s/attachment' % bid).json()

Looks like there is another call here.

I'll fix this locally and land once tests have passed.

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/6c9b6024110a6f2d3d41836526c02a48b92f8150
Upgrade Bugsy to v0.6.0 (Bug 1212856) r=gps

Comment 7

[David Burns :automatedtester]

I believe that gps landed this so am closing.