Node.isEqualNode() on doctypes should ignore internal subsets

RESOLVED FIXED in Firefox 44

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

We fail a test here because of this: http://w3c-test.org/dom/nodes/Node-isEqualNode.xhtml

Spec: https://dom.spec.whatwg.org/#concept-node-equals

The original DOM 3 Core spec said to take internal subsets into account, unlike current DOM: http://www.w3.org/TR/DOM-Level-3-Core/core.html#Node3-isEqualNode

IE matches the old DOM 3 Core behavior, as do we.  Chrome follows the new DOM spec.  I don't know why the spec changed.  Anne, Ms2ger, do you?
Flags: needinfo?(annevk)
Flags: needinfo?(Ms2ger)

Comment 1

2 years ago
The specification has dropped internal subsets as a concept that you keep around for DocumentType objects. So they simply don't exist and therefore are not compared.
Flags: needinfo?(annevk)
Created attachment 8672382 [details] [diff] [review]
Patch

Aha, thanks.  We want to get rid of those anyway (bug 801545), so this makes sense.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=04f3231c1c8b
Flags: needinfo?(Ms2ger)
Attachment #8672382 - Flags: review?(bzbarsky)
Comment on attachment 8672382 [details] [diff] [review]
Patch

r=me
Attachment #8672382 - Flags: review?(bzbarsky) → review+

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/05958d6e51fb
https://hg.mozilla.org/mozilla-central/rev/05958d6e51fb
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.