1212905 - [New-Homescreen] Make scroll-snapping optional, disabled by default

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Chris Lord [:cwiiis]]

UX doesn't like scroll snapping (:'(), but have agreed to an option in the developer settings. This has some interesting implications for performance and dragging icons, we'll have to see how it works out...

This will depend on some settings infrastructure added in bug 1212864.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1212905-new-homescreen-optional-scroll-snapping > mozilla-b2g:master

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 8671895 [details] [review]
[gaia] Cwiiis:bug1212905-new-homescreen-optional-scroll-snapping > mozilla-b2g:master

r?gmarty for homescreen changes, r?gasolin for settings changes.

This adds a homescreen preference for paging - when paging is enabled, behaviour is as it is now, when it's disabled, scroll-snapping is disabled and auto-scroll during icon dragging just scrolls a logical page up/down without snapping to 'page' boundaries.

Comment 3

[Guillaume Marty [:gmarty]]

Comment on attachment 8671895 [details] [review]
[gaia] Cwiiis:bug1212905-new-homescreen-optional-scroll-snapping > mozilla-b2g:master

That's cool. r+
Glad we kept this feature.

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 8671895 [details] [review]
[gaia] Cwiiis:bug1212905-new-homescreen-optional-scroll-snapping > mozilla-b2g:master

I've refactored settings into a separate object (with unit testing), but I think the change is large enough to warrant re-review.

Comment 5

[Guillaume Marty [:gmarty]]

Comment on attachment 8671895 [details] [review]
[gaia] Cwiiis:bug1212905-new-homescreen-optional-scroll-snapping > mozilla-b2g:master

Looks better. Having the settings details abstracted away makes everything more readable. r+ for the homescreen bit.

Comment 6

[[e-mail]]

Comment on attachment 8671895 [details] [review]
[gaia] Cwiiis:bug1212905-new-homescreen-optional-scroll-snapping > mozilla-b2g:master

Looks good, please also update `build/config/common-settings.json` if there's a new settings key.

Comment 7

[Chris Lord [:cwiiis]]

Comment on attachment 8671895 [details] [review]
[gaia] Cwiiis:bug1212905-new-homescreen-optional-scroll-snapping > mozilla-b2g:master

There are no new settings keys added, the value that gets poked is a datastore value.

Comment 8

[[e-mail]]

Comment on attachment 8671895 [details] [review]
[gaia] Cwiiis:bug1212905-new-homescreen-optional-scroll-snapping > mozilla-b2g:master

then it looks fine to me

Comment 9

[Chris Lord [:cwiiis]]

Cheers, merged: https://github.com/mozilla-b2g/gaia/commit/9cb5b8f2de48f458eae736c7dd3633b5c5782c90