1212918 - add web activity so add-on manager + opens Marketplace

Status: VERIFIED FIXED

(Marketplace Graveyard :: General, defect, P1)

Description

[Andrew Williamson [:eviljeff]]

Currently the (+) button in settings|addons shows an in-app list of add-ons to install.  This list is retrieved from Hackerplace [1], specifically [2] and installs are performed with zip files from 3rd party websites.

When distribution is offered via Firefox Marketplace instead this should be a link/integration to Marketplace.

[1] https://github.com/fxos/directory
[2] https://github.com/fxos/directory/blob/master/app/apps-v2.json

Comment 1

[Andrew Williamson [:eviljeff]]

[Blocking Requested - why for this release]: see #c0

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

This is on Marketplace's plate. The '+' sign opens the install web activity which Hackerplace handles [2]. To make it direct to Marketplace, Marketplace will have to handle this activity in a similar way.

1.) https://github.com/mozilla-b2g/gaia/blob/c7df972bf6ac24769cc2f74a80c48dfaedcdb040/apps/settings/js/panels/addons/panel.js#L19-L22
2.) https://github.com/fxos/directory/blob/9c6e805b37bb0af3973ad9b3538515070f7b06fe/app/manifest.webapp#L31-L37

Comment 3

[Andrew Williamson [:eviljeff]]

We probably want this to land at the same time as the frontend switch to enable add-ons gets removed.

Comment 4

[Mathieu Pillard [:mat]]

"install" is way too generic. I propose to change gaia to use "marketplace-category" with slug "addons", which already exists, and we'll add the necessary code to support that.

Comment 5

[David Durst [:ddurst]]

(In reply to Mathieu Pillard [:mat] from comment #4)
> "install" is way too generic. I propose to change gaia to use
> "marketplace-category" with slug "addons", which already exists, and we'll
> add the necessary code to support that.

I believe homescreens is already exactly like that, fwiw.

Comment 6

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/fireplace/commit/9c3b682ae8ded6140f1658ef923886f2faf34089 (but we still need gaia to fix bug 1216322 to use the new marketplace-category + "addons" slug)

Comment 7

[Mike Lien[:mlien]]

verified and fixed with Aries build ID 20151029010303