Closed
Bug 1212921
Opened 10 years ago
Closed 10 years ago
Regression: Default top-site thumbnails missing
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 1.1+ | --- |
People
(Reporter: aaronmt, Assigned: sleroux)
References
Details
(Keywords: regression)
Attachments
(2 files)
Screen Shot 2015-10-08 at 12.11.54 PM.png
See screenshot.
* Build master (8caea70fe6e7eea77f10ef3098df316a3b72c4fc)
* Launch browser
* See Top Sites
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → sleroux
|
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
So turns out the root of the black tile issue wasn't that the image background was black but that the blur effect renders as black if there is nothing to blur behind it which is why it was black until the background image came. I've added toggling of the alpha on the effect view whenever we set/unset the image. This isn't the most elegant since we need to make sure to toggle alpha state every time we set the image but I'm hoping to make this better in the Top Sites Panel refactor.
Attachment #8671469 -
Flags: ui-review?(dhenein)
Attachment #8671469 -
Flags: review?(bnicholson)
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8671469 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1139
Our Top Sites code has gotten pretty complicated...looking forward to that refactor!
Attachment #8671469 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Merged
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Attachment #8671469 -
Flags: ui-review?(dhenein)
You need to log in
before you can comment on or make changes to this bug.
Description
•