Closed Bug 1212966 Opened 9 years ago Closed 9 years ago

Hide the reviewer tools from people who have no access

Categories

(Marketplace Graveyard :: Reviewer Tools, defect)

Product:
Marketplace Graveyard
Component:
Reviewer Tools
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: krupa.mozbugs, Assigned: chuck)

References

Details

steps to reproduce: 1. Sign in to /content with an account which only has Add-on Submitter access expected behavior: Reviewer tools section is hidden actual behavior: API returns a 403 but the Review Add-ons section is still visible. We should hide that section from people with no access.
https://github.com/mozilla/marketplace-content-tools/commit/2cc8e17f63ea5d82f8d9e6ec8f13c60425274dfb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified as fixed on MP-dev FF44(Win 7). Postfix screencast: http://screencast.com/t/82b6AuhB As we can see in the screencast, the Review Add-on section is no longer visible for no-access account. But I have a question: the submission of an Add-on shouldn't be available, also?
Flags: needinfo?(charmston)
There are separate permissions required to log in to the content tools (we use this one to selectively show or hide a link in the consumer pages), submit addons, and review addons.
Flags: needinfo?(charmston)
Base on comment 2 and comment 3 I will mark this as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.