1212968 - JPM based add-ons are completely broken by bug 1202902

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Comment 1

[Dave Townsend [:mossop]]

Attachment: pull request for jpm-core

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8671503 [details] [review]
pull request for jpm-core

r+. Incremented jpm-core to 0.0.11, published;
Updated jpm to use jpm-core/0.0.11, published and tagged as 1.0.2
https://github.com/mozilla-jetpack/jpm/releases/tag/1.0.2

Comment 4

[Benoit Girard (:BenWa)]

I only see a change to JPM here. What about extensions that are already built and signed? Are we not fixing that?

Comment 5

[Dave Townsend [:mossop]]

(In reply to Benoit Girard (:BenWa) from comment #4)
> I only see a change to JPM here. What about extensions that are already
> built and signed? Are we not fixing that?

Bug 1213102 is going to try to do that for AMO hosted add-ons.

Comment 6

[Benoit Girard (:BenWa)]

What about non-listed add-ons? This is silly add-on bustage. Are we really wanting to require these developers to get find this bug, update jetpack, get their add-on updated, resubmit to AMO for signing and deploy the update?

Comment 7

[Dave Townsend [:mossop]]

(In reply to Benoit Girard (:BenWa) from comment #6)
> What about non-listed add-ons? This is silly add-on bustage. Are we really
> wanting to require these developers to get find this bug, update jetpack,
> get their add-on updated, resubmit to AMO for signing and deploy the update?

We're planning some outreach to warn add-on developers that this is coming. Unfortunately it doesn't look like be compatible with the JavaScript spec without breaking some add-ons.

Comment 8

[Benoit Girard (:BenWa)]

We already detect if a bootstrap addon doesn't have a main method. If that happens why not look if it's a JPM and do some extra step to find the methods. Sounds a lot easier for us to make the change then to require all the addons to do it and get resigned.

Comment 9

[Dave Townsend [:mossop]]

(In reply to Benoit Girard (:BenWa) from comment #8)
> We already detect if a bootstrap addon doesn't have a main method. If that
> happens why not look if it's a JPM and do some extra step to find the
> methods.

As far as I know there are no steps we can take to find the methods, that's the point of the new lexical scope, it is inaccessible outside of the script. If I'm wrong then by all means file a bug to do that. If you want to talk about other options then please take it to dev-addons for wider discussion.

Comment 11

[Dave Townsend [:mossop]]

Turns out there is a way to access the new scope so I think we can fix existing add-ons directly in bug 1217070