1212975 - Make theme-switching.js work with addons

Status: NEW

(DevTools :: Framework, defect)

Description

[Brian Grinstead [:bgrins]]

Not sure if it's calls to Services, Components, or what, but apparently theme-switching.js doesn't work with SDK addons.  Usually this file is loaded as a <script> tag, so maybe that's the issue.

Maybe the call to hiddenDOMWindow in https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/theme-switching.js#49?
Or Services: https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/theme-switching.js#113
Or Components: https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/theme-switching.js#103

Anyhow, we should make it easy for addons to use the theme-switching functionality.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

If access to Components is the problem but we do have SDK require, we can do something like:

   var Components_ = require ? require("chrome").components : Components;