1212982 - ClearType parameters in about:support don't show if user never tweaked with ClearType Tuner

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[fireattack [:fireattack]]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151005144425

Steps to reproduce:

"ClearType Parameters" don't show in about:support's graphics section if on Win 7. Win 10 works fine.

Comment 1

[fireattack [:fireattack]]

According to this article, http://www.theeldergeek.com/activate_cleartype_on_welcome_screen.htm

At least for some in Win 7 system, the parameters of clear type is stored in 
HKEY_CURRENT_USER\Control Panel\Desktop
with Values names such as "FontSmoothing", "FontSmoothingGamma", and so on.

It's not in HKCU\Software\Microsoft\Avalon.Graphics or HKLM\Software\Microsoft\Avalon.Graphics

Comment 2

[fireattack [:fireattack]]

It looks like that if you never run the ClearType tuner, these registries in \Software\Microsoft\Avalon.Graphics won't exist (while user still have some kind of ClearType settings..).

Comment 3

[John Daggett (:jtd)]

Sorry, don't know the answer here.

Comment 4

[YF (Yang)]

We may not be necessary to get the not changed values. It should not cause a problem usually (just a hypothetical). And we may not have a way to get the current value or the default value at least for now.

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: Get ClearType parameters using API instead of reading registry

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: Get ClearType parameters using API instead of reading registry

Added a DWriteEnabled() check.

Comment 7

[Masatoshi Kimura [:emk]]

Ping?

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Sorry for not looking at this sooner. I'm not sure I understand the motivation here. Can you improve the commit message so that the reason for the change is clearer?

Comment 9

[Masatoshi Kimura [:emk]]

Attachment: Get ClearType parameters using API instead of reading registry

This patch is changing a way to get ClearType paramters because registry key
may not be present. CreateMonitorRenderingParams() will return default values
if the corresponding registry key is not present.

Comment 10

[Masatoshi Kimura [:emk]]

I updated the commit message.

Comment 11

[Masatoshi Kimura [:emk]]

Jeff, please tell me if the commit message is still insufficient.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9042436 [details] [diff] [review]
Get ClearType parameters using API instead of reading registry

Review of attachment 9042436 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry. I forgot about this. It's fine.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37069977b1e6
Get ClearType parameters using API instead of reading registry. r=jrmuizel

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/37069977b1e6