121299 - Need cookie icon for status bar

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[Stephen P. Morse]

We need to have a status-bar cookie icon, and have it included in cvs and in the 
build.  See bug 121161 for details of why and where we need this icon.

Comment 1

[Stephen P. Morse]

Marlon,

I have created a temporary icon in the patch for bug 121161.  Can you provide us 
with a better one or should be go with that one?

Comment 2

[Stephen P. Morse]

Temporary icon has been checked in.  Reassigning to Marlon if he wants to 
produce a better one.  Otherwise close this out and we go with my icon.

Comment 3

[marlon bishop]

mmmm, cookie icons. accepting

Comment 4

[Neil Marshall]

Would this icon solve Bug 113092

Comment 5

[Stephen P. Morse]

No it wouldn't.  The cookie icon here is to indicate if a cookie decision has 
been made based on a p3p setting.  Bug 113092 is asking for an indicator if a 
cookie has been set.  So, unless the spec is changed, these are two different 
things.

Comment 6

[Lori Kaplan]

approving. Needed for release.

Comment 7

[Ian Pottinger]

adding self to cc list

Comment 8

[marlon bishop]

what we have now should suffice for beta. there will definitely be final icon
coming for RTM (still possibility for getting it done in beta, but no guarantee) 

Comment 9

[scottputterman]

adding [adt1 rtm] based on Marlon's comments.  We'd ship beta with the current icon.

Comment 10

[gail]

Attachment: zip file containing 2 transparent gifs

Here are transparent icons - one for each skin.

Modern:  16px W x 13 px H
filename: cookyM.gif

Classic: 16px W x 12px H
filename: cookyC.gif

Comment 11

[Scott MacGregor]

Attachment: TRUNK patch to use the new icons provided by UE

I know Steve has much bigger fish to fry so I put together a patch to add the
cookie icons Gail kindly provided onto the trunk.

Attaching a screen shot next showing the new icons.

Comment 12

[Scott MacGregor]

Attachment: classic and modern screen shots of the new cookie icon

Comment 13

[Stephen P. Morse]

Looks good to me.  r=morse

Comment 14

[Scott MacGregor]

Thanks Steve. Acceping this bug. I'll try to get it in tonight. 

Comment 15

[(not reading, please use [e-mail] instead)]

Comment on attachment 81062 [details] [diff] [review]
TRUNK patch to use the new icons provided by UE

sr=sspitzer

Comment 16

[Scott MacGregor]

This is now fixed on the TRUNK.

If Marlon has a new image tomorrow which he wants to use instead, it becomes
extremely easy to use that icon. 

I'll post a much simpler patch for the branch which just replaces the existing
icon in content instead of creating a skins directory with separate classic and
modern icons. 

We'll also want to file a spin off bug for the screen shot image which you see
when you click on the icon. 

Marking this fixed.

Comment 17

[Scott MacGregor]

Attachment: simplified moz 1.0 BRANCH fix

This patch would be for the moz 1.0 branch. It is even less complex than the
trunk patch. It just replaces the existing gif with the new gif.

Comment 18

[Scott MacGregor]

I also checked in a new image for the image of the cookie status notification
that shows up in the p3p dialog. 

Comment 19

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) approval for checkin to the 1.0 branch. Pls check
this in tonight (if possible), then add the fixed1.0.0 keyword. thanks!

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 81069 [details] [diff] [review]
simplified moz 1.0 BRANCH fix

a=dbaron for 1.0 branch checkin (as if I could tell anything from the patch)

Comment 21

[Scott MacGregor]

Ok, the simplified fix is now in the 1.0 branch. 

Here's what we've got:

TRUNK:
1) New cookie icons for modern AND classic
2) New cookie screen shot icon (for the manager dialog) for modern AND classic

BRANCH:
1) New cookie icon shared by both modern and classic
2) New cookie screen shot icon (for the manager dialog) shared by both modern
and classic.

Marking this as fixed on the branch.

Comment 22

[Scott MacGregor]

One last thing:

TRUNK:
1) Image referenced by the help files were changed to point to the new images

BRANCH
1) No changes were made to the help documentation so they'll still use the old
image with the white background.

Comment 23

[[e-mail]]

Speaking as a skin designer, I do hate it when people use skin URLs in content,
is there any chance you can change this to use CSS rules in the skin instead?

Comment 24

[Scott MacGregor]

*** Bug 140105 has been marked as a duplicate of this bug. ***

Comment 25

[Tom Everingham]

verified both trunk and branch, 05/28/02 winNT4, linux rh6, mac osX

Comment 26

[Stephen P. Morse]

New icon checked in on both branch and trunk at lorikaplan's request