Closed Bug 1213040 Opened 9 years ago Closed 7 years ago

Determine if we can improve the clobber action for Windows jobs

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: armenzg, Unassigned)

References

(Blocks 1 open bug)

Details

The clobber step can take around 1 minute [1].

From the output [1], it is difficult to tell if we're using the right command.

In bug 727551 we deployed a Windows-native alternate to msys rm.exe.
Based on:
https://github.com/vvuk/winrm

There is also some speed up wins:
https://bugzilla.mozilla.org/show_bug.cgi?id=727551#c57

'rmdir /S /Q "%s"' % path)

If we look at the code [2], it's hard to tell if we:
* line 260 - rmdir /S /Q "%s"' % path
or:
* win32file.DeleteFile() + win32file.RemoveDirectory()

The two alternatives depend if win32file/win32api can be loaded or not [3].

In either way (IIUC) we don't take advantage of bug 727551

We need some more debugging output plus try forcing one way or another for better timings.

[1]
12:09:11     INFO - retry: Calling _rmtree_windows with args: ('C:\\slave\\test\\build',), kwargs: {}, attempt #1
12:10:01     INFO - Running post-action listener: _resource_record_post_action
[2]
https://dxr.mozilla.org/mozilla-central/rev/6256ec9113c115141aab089c45ee69438884b680/testing/mozharness/mozharness/base/script.py#236
[3]
https://dxr.mozilla.org/mozilla-central/rev/6256ec9113c115141aab089c45ee69438884b680/testing/mozharness/mozharness/base/script.py#32
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.