Closed Bug 1213080 Opened 10 years ago Closed 10 years ago

Update requirements for requests==2.7.0 and mozdownload==1.18

Categories

(Testing :: Firefox UI Tests, defect)

defect
Not set
normal

Tracking

(firefox41 fixed, firefox42 fixed, firefox43 fixed, firefox44 fixed, firefox-esr38 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox41 --- fixed
firefox42 --- fixed
firefox43 --- fixed
firefox44 --- fixed
firefox-esr38 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

Details

Attachments

(1 file)

In mozdownload we have a restriction for requests==2.7.0 and we install it via the create_venv.py script if the --with-optional parameter is given. If also --strict is used we fail to use mozdownload: raise VersionConflict(dist, req).with_context(dependent_req) pkg_resources.ContextualVersionConflict: (requests 2.8.0 (/mozilla/code/mozmill-ci/jenkins-master/jobs/scripts/workspace/tests_venv/lib/python2.7/site-packages), Requirement.parse('requests==2.7.0'), set(['mozdownload'])) We should better also pin the version of requests in the requirements.txt. Beside that we should update the mozdownload dependency to 1.18.
We would need this for all branches.
Attachment #8671648 - Flags: review?(mjzffr)
Comment on attachment 8671648 [details] [review] github_pull_request.txt lgtm
Attachment #8671648 - Flags: review?(mjzffr) → review+
Target Milestone: --- → Firefox 44
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: