1213080 - Update requirements for requests==2.7.0 and mozdownload==1.18

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

In mozdownload we have a restriction for requests==2.7.0 and we install it via the create_venv.py script if the --with-optional parameter is given. If also --strict is used we fail to use mozdownload:

    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (requests 2.8.0 (/mozilla/code/mozmill-ci/jenkins-master/jobs/scripts/workspace/tests_venv/lib/python2.7/site-packages), Requirement.parse('requests==2.7.0'), set(['mozdownload']))

We should better also pin the version of requests in the requirements.txt. Beside that we should update the mozdownload dependency to 1.18.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We would need this for all branches.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: github_pull_request.txt

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8671648 [details] [review]
github_pull_request.txt

lgtm

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Merged PR to mozilla-central:
https://github.com/mozilla/firefox-ui-tests/commit/0258610df1fd2f7233807d338436781f6504f67a

Will backport it tomorrow.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Backported the patch to all the other branches:

https://github.com/mozilla/firefox-ui-tests/commit/5bbb1530132502fba8f2320963eac20480e6c6b5 (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/083622fde57cd64eb94010eec50dbc2a8fa6835a (beta)
https://github.com/mozilla/firefox-ui-tests/commit/a6eeb53f66116a9ba64af1bef9613008204894c7 (release)
https://github.com/mozilla/firefox-ui-tests/commit/1abaa0c3cf09fd1ad1df01cb66e19d70068ab41a (esr38)