Closed
Bug 1213080
Opened 10 years ago
Closed 10 years ago
Update requirements for requests==2.7.0 and mozdownload==1.18
Categories
(Testing :: Firefox UI Tests, defect)
Testing
Firefox UI Tests
Tracking
(firefox41 fixed, firefox42 fixed, firefox43 fixed, firefox44 fixed, firefox-esr38 fixed)
RESOLVED
FIXED
mozilla44
People
(Reporter: whimboo, Assigned: whimboo)
Details
Attachments
(1 file)
In mozdownload we have a restriction for requests==2.7.0 and we install it via the create_venv.py script if the --with-optional parameter is given. If also --strict is used we fail to use mozdownload:
raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (requests 2.8.0 (/mozilla/code/mozmill-ci/jenkins-master/jobs/scripts/workspace/tests_venv/lib/python2.7/site-packages), Requirement.parse('requests==2.7.0'), set(['mozdownload']))
We should better also pin the version of requests in the requirements.txt. Beside that we should update the mozdownload dependency to 1.18.
Assignee | ||
Comment 1•10 years ago
|
||
We would need this for all branches.
status-firefox41:
--- → affected
status-firefox42:
--- → affected
status-firefox43:
--- → affected
status-firefox44:
--- → affected
status-firefox-esr38:
--- → affected
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8671648 -
Flags: review?(mjzffr)
Comment on attachment 8671648 [details] [review]
github_pull_request.txt
lgtm
Attachment #8671648 -
Flags: review?(mjzffr) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Merged PR to mozilla-central:
https://github.com/mozilla/firefox-ui-tests/commit/0258610df1fd2f7233807d338436781f6504f67a
Will backport it tomorrow.
Target Milestone: --- → Firefox 44
Assignee | ||
Comment 5•10 years ago
|
||
Backported the patch to all the other branches:
https://github.com/mozilla/firefox-ui-tests/commit/5bbb1530132502fba8f2320963eac20480e6c6b5 (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/083622fde57cd64eb94010eec50dbc2a8fa6835a (beta)
https://github.com/mozilla/firefox-ui-tests/commit/a6eeb53f66116a9ba64af1bef9613008204894c7 (release)
https://github.com/mozilla/firefox-ui-tests/commit/1abaa0c3cf09fd1ad1df01cb66e19d70068ab41a (esr38)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Updated•9 years ago
|
Product: Mozilla QA → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•