1213090 - Implement PageWithHeader

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

Follow-up from bug 1203456, comment 9 and bug 1203456, comment 10:
"
Just thought class GaiaHeader doesn't work like bug description.

from the description I suppose to use it like

class PageWithHeader(Base, GaiaHeader):

and you can call 

PageWithHeader.go_back()

without extra wrapping.
"

"
Paul has a great point! Inheriting from PageWithHeader is a good thing. We couldn't do it with the GaiaSwitch and such because we might have many switches in one single page.

I think the PR is good as is, and we can perform the inheritance in a follow up. Unless you want to handle it in this PR, Martijn.
"

In bug 1203456, GaiaHeader was implemented. There are quite some pages that have a go_back() function implemented.
By making a PageWithHeader class, we can standardize and centralize this in one spot.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] JohanLorenzo:bug-1213090 > mozilla-b2g:master

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8675678 [details] [review]
[gaia] JohanLorenzo:bug-1213090 > mozilla-b2g:master

After some investigation, I'm not sure if the use of GaiaHeader is generic enough. Here's a PR where I started the work, but I came across some issues. I wrote some comments. I'd like your point of view on them.

Comment 3

[Martijn Wargers (dead)]

So for me, using contact_details.header.go_back() would be easier to understand for me than another class like PageWithHeader, but I know you pointed me out to some articles that's frowned upon.

Comment 4

[Paul Yang [:pyang] (away)]

Comment on attachment 8675678 [details] [review]
[gaia] JohanLorenzo:bug-1213090 > mozilla-b2g:master

from the implementation I feel we still need to overwrite go_back function for every page.
Take this for instance http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/email/app.py#133

go_back() function should serve a page instance so caller can aware page is changed.  If that is the case, every page should have its own go_back by transition logic.

Need more thought for this.

Comment 5

[Martijn Wargers (dead)]

Marking WONTFIX, sorry for the bug spam. If somebody still wants to work on this, please file a new bug for it.