Closed Bug 1213120 Opened 4 years ago Closed 4 years ago

Intermittent 2d.drawImage.canvas.html | application crashed [@ mozilla::layers::CompositorParent::GetAPZCTreeManager(unsigned long)]

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: KWierso, Assigned: kats)

References

Details

(Keywords: intermittent-failure, Whiteboard: [gfx-noted])

Attachments

(1 file)

Comment on attachment 8681991 [details] [diff] [review]
Patch

Review of attachment 8681991 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/CompositorParent.cpp
@@ +1649,5 @@
>  
>  /*static*/ APZCTreeManager*
>  CompositorParent::GetAPZCTreeManager(uint64_t aLayersId)
>  {
> +  EnsureLayerTreeMapReady();

This looks fine, but why not just put in GetIndirectShadowTree or when constructing CompositorChild?
Attachment #8681991 - Flags: review?(bgirard) → review+
I didn't want to put it in GetIndirectShadowTree because that gets called from a bunch of places and not all of them need this (in most cases the map is already initialized). Also I wasn't entirely sure that's only called from the main thread. As for CompositorChild I think that doesn't get created until after in this particular case.
https://hg.mozilla.org/mozilla-central/rev/c615bf9eae4f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Looks like there are still some instances of this after the patch landed :(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I'm going to close this bug again, so that people starring failures send them to bug 1223706 instead (which is basically the same thing). FIXED because we landed a patch in this bug, even though it didn't actually fix the problem. Otherwise duplicate might make more sense.
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.