1213127 - Use the jstests test runner to dispatch jit-tests in parallel

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: switch_jittests_to_jstests_task_runner-v0.diff

IIRC, this failed on try because we weren't setting some env var properly, so holding off on review for now. Should be simple enough to fix:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd0d33b081f6

Comment 1

[Terrence Cole [:terrence]]

As expected, this was not sufficient. Linux is missing P.?_.* shaped symbols, so I think the failure is that we're no longer setting the LD_LIBRARY_PATH variable to the shell's directory. I've fixed this in bug 1213365.

The windows tests get further, surprisingly, but still fall over at options.run_skipped. In the linux runner, this variable is only accessed conditional on test.enabled (which is forced to always be true, since we filter for "slow" tests elsewhere); however, in the windows runner, we pass it to a function, so it needs to always be present. I'll upload a new patch for that.

Comment 2

[Terrence Cole [:terrence]]

Attachment: switch_jittests_to_jstests_task_runner-v1.diff

Appears to be green with those changes.

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8672076 [details] [diff] [review]
switch_jittests_to_jstests_task_runner-v1.diff

Review of attachment 8672076 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/lib/jittests.py
@@ +8,5 @@
>  
>  from __future__ import print_function
>  import os, posixpath, sys, tempfile, traceback, time
>  import subprocess
> +from collections import namedtuple

Ooh, namedtuple looks nice. I can use that.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bdcc2a6af89a

Comment 5

[Terrence Cole [:terrence]]

(In reply to Steve Fink [:sfink, :s:] from comment #3)
> Comment on attachment 8672076 [details] [diff] [review]
> switch_jittests_to_jstests_task_runner-v1.diff
> 
> Review of attachment 8672076 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/tests/lib/jittests.py
> @@ +8,5 @@
> >  
> >  from __future__ import print_function
> >  import os, posixpath, sys, tempfile, traceback, time
> >  import subprocess
> > +from collections import namedtuple
> 
> Ooh, namedtuple looks nice. I can use that.

It bridges the gap pretty well between passing around brittle tuples and full-blown classes (which have to have a boilerplate __init__, at the very least).

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bdcc2a6af89a