Closed
Bug 1213129
Opened 10 years ago
Closed 10 years ago
Share the code we use to get worker counts for the test suites
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
6.67 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
The jstests suite has a simple get_worker_count routine that checks a few reliable places for core counts.
The lib/jittests.py script, on the other hand, sets HAVE_MULTIPROCESSING to True when it does the import, which includes adding cpu_count to the lib/jittests.py namespace. This is imported first by jit_tests.py, which does the above. Later (relatively), when jit_tests.py sets up the argument processor, it checks jittests.HAVE_MULTIPROCESSING before calling jittests.get_cpucount. Because we wouldn't want to be crazy and re-used the loader's cached copy? Who knows!
I've chosen to standardize on the first of these methods.
Attachment #8671697 -
Flags: review?(sphink)
Updated•10 years ago
|
Attachment #8671697 -
Flags: review?(sphink) → review+
Comment 2•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•