Share the code we use to get worker counts for the test suites

RESOLVED FIXED in Firefox 44

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8671697 [details] [diff] [review]
share_worker_count_code-v0.diff

The jstests suite has a simple get_worker_count routine that checks a few reliable places for core counts.

The lib/jittests.py script, on the other hand, sets HAVE_MULTIPROCESSING to True when it does the import, which includes adding cpu_count to the lib/jittests.py namespace. This is imported first by jit_tests.py, which does the above. Later (relatively), when jit_tests.py sets up the argument processor, it checks jittests.HAVE_MULTIPROCESSING before calling jittests.get_cpucount. Because we wouldn't want to be crazy and re-used the loader's cached copy? Who knows!

I've chosen to standardize on the first of these methods.
Attachment #8671697 - Flags: review?(sphink)
Attachment #8671697 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/3b9d138a6f95
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.