1213135 - Shared action_menu is missing oval button background for cancel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Shared, defect)

Description

[Kevin Grandon :kgrandon]

Spinning this off of bug 1196268.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1213135_shared_action_menu_bg > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8671705 [details] [review]
[gaia] KevinGrandon:bug_1213135_shared_action_menu_bg > mozilla-b2g:master

R+ing this based on the feedback in bug 1213135 already, I'm going to go with f=julien r=kgrandon.

Comment 3

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/9a196512116ead92e72967fa52d245582582fc67

Comment 4

[Kevin Grandon :kgrandon]

Ok, this breaks some places due to specificity changes - turns out we may need the more specific selector after all. Backing out and re-opening to get a better fix: https://github.com/mozilla-b2g/gaia/commit/9448a125bb3bba82987a92e670a1032db4b236aa

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:reland_bug_1213135 > mozilla-b2g:master

Comment 6

[Julien Wajsberg [:julienw]]

Can you share which places this breaks ? Is it that the 'cancel' button is now placed as the other buttons (which is just the container missing), or is it something else ?

Comment 7

[Kevin Grandon :kgrandon]

(In reply to Julien Wajsberg [:julienw] from comment #6)
> Can you share which places this breaks ? Is it that the 'cancel' button is
> now placed as the other buttons (which is just the container missing), or is
> it something else ?

Yes - the button seemed to be "placed" differently due to the CSS and removing last-child selectors. My thought were that we should back this out, and fix everything, but now that's seeming like too difficult a task. Ideally we'd switch to use the gaia-menu component everywhere, but I don't think I'll have time to port everything, maybe for a future release.

For now I think re-landing, filing issues for other places that are broken and following up with individual fixes would be best.

Comment 8

[Kevin Grandon :kgrandon]

Re-landing: https://github.com/mozilla-b2g/gaia/commit/d6cc7ef0b409af4b83d0d1ccc7c1f4ddba28284e

(Other places still broken, but following those up in bug 1213614 and bug 1213615).

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1213614_system_action_menu_cancel_bg > mozilla-b2g:master

Comment 10

[Julien Wajsberg [:julienw]]

Yeah I think the issue is simply to add the container everywhere. There is no specificity issue.