1213147 - Use Roboto Light for title in Share Overlay dialog on API 16+

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

In overlay_share_dialog [1], the title (and only the title) element should have the font as Roboto Light on API 16+. In [2], it states you can do this with fontFamily=sans-serif-light & textStyle=normal. This will ideally go directly in the overlay_share_dialog XML but I'm not sure if this would crash on lower API levels. If so, put this into a textAppearance.

[1]: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/overlay_share_dialog.xml
[2]: http://stackoverflow.com/a/19692168

Comment 1

[Tushar Saini (:shatur)]

Attachment: Bug-1213147.patch

Hi,
    Please review, and let me know if further changes are required.
I have tested it on my device(API 22).

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

@shatur: Thank you for the patch! Can you upload a screenshot of the dialog and flag :antlam for feedback?

Comment 3

[Tushar Saini (:shatur)]

Attachment: How it looks now.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8730801 [details]
How it looks now.

Looks good! thanks!

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8730792 [details] [diff] [review]
Bug-1213147.patch

Review of attachment 8730792 [details] [diff] [review]:
-----------------------------------------------------------------

The code looks good. Did you test this on a device or emulator with API level 15 (Android 4.0.x)? Roboto Light isn't available with that version and we should take care that this does not crash.

Comment 6

[Tushar Saini (:shatur)]

Attachment: screenshot

Hi,
    I have tested this patch on emulator running on API level 15. This is how it looks. 

Regards

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Thank you, shatur. I'll land this patch.

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/bca2e4c24f17403364997638d9356c6a63ffafec
Bug 1213147 - Use Roboto Light for title in Share Overlay dialog on API 16+. r=sebastian

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bca2e4c24f17