Closed Bug 1213147 Opened 5 years ago Closed 5 years ago

Use Roboto Light for title in Share Overlay dialog on API 16+

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: mcomella, Assigned: shatur, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=java][lang=xml][good next bug])

Attachments

(3 files)

In overlay_share_dialog [1], the title (and only the title) element should have the font as Roboto Light on API 16+. In [2], it states you can do this with fontFamily=sans-serif-light & textStyle=normal. This will ideally go directly in the overlay_share_dialog XML but I'm not sure if this would crash on lower API levels. If so, put this into a textAppearance.

[1]: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/overlay_share_dialog.xml
[2]: http://stackoverflow.com/a/19692168
Hi,
    Please review, and let me know if further changes are required.
I have tested it on my device(API 22).
Attachment #8730792 - Flags: review?(s.kaspari)
Assignee: nobody → tushar.saini1285
Status: NEW → ASSIGNED
@shatur: Thank you for the patch! Can you upload a screenshot of the dialog and flag :antlam for feedback?
Attached image How it looks now.
Attachment #8730801 - Flags: feedback?(alam)
Comment on attachment 8730801 [details]
How it looks now.

Looks good! thanks!
Attachment #8730801 - Flags: feedback?(alam) → feedback+
Comment on attachment 8730792 [details] [diff] [review]
Bug-1213147.patch

Review of attachment 8730792 [details] [diff] [review]:
-----------------------------------------------------------------

The code looks good. Did you test this on a device or emulator with API level 15 (Android 4.0.x)? Roboto Light isn't available with that version and we should take care that this does not crash.
Attachment #8730792 - Flags: review?(s.kaspari) → review+
Attached image screenshot
Hi,
    I have tested this patch on emulator running on API level 15. This is how it looks. 

Regards
Attachment #8732854 - Flags: feedback?(s.kaspari)
Thank you, shatur. I'll land this patch.
Attachment #8732854 - Flags: feedback?(s.kaspari) → feedback+
https://hg.mozilla.org/mozilla-central/rev/bca2e4c24f17
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.