Some nsIInterceptedChannel cleanup

RESOLVED FIXED in Firefox 44

Status

()

Core
DOM: Service Workers
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox43 wontfix, firefox44 fixed)

Details

Attachments

(3 attachments)

This doesn't need to block v1 but I'm nominating it for easier tracking of the uplifts.  I have some cleanup patches.
(Assignee)

Comment 1

3 years ago
Created attachment 8671713 [details] [diff] [review]
Part 1: Add a nsContentUtils::IsNonSubresourceRequest helper
Attachment #8671713 - Flags: review?(josh)
(Assignee)

Comment 2

3 years ago
Created attachment 8671714 [details] [diff] [review]
Part 2: Rework ShouldPrepareForIntercept() in terms of subresource requests
Attachment #8671714 - Flags: review?(josh)
(Assignee)

Comment 3

3 years ago
Created attachment 8671715 [details] [diff] [review]
Part 3: Remove nsIInterceptedChannel.isNavigation
Attachment #8671715 - Flags: review?(josh)

Updated

3 years ago
Status: NEW → ASSIGNED

Updated

3 years ago
Attachment #8671713 - Flags: review?(josh) → review+

Updated

3 years ago
Attachment #8671714 - Flags: review?(josh) → review+

Updated

3 years ago
Attachment #8671715 - Flags: review?(josh) → review+
(Assignee)

Comment 6

3 years ago
Comment on attachment 8671713 [details] [diff] [review]
Part 1: Add a nsContentUtils::IsNonSubresourceRequest helper

These are cleanup patches that would be nice to backport to Aurora for easier uplift of service worker changes.  They should not affect anything but service workers.
Attachment #8671713 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/402e89017708
https://hg.mozilla.org/mozilla-central/rev/ff1551e09f8f
https://hg.mozilla.org/mozilla-central/rev/57541b82c71e
https://hg.mozilla.org/mozilla-central/rev/9d24051f4449
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8671713 [details] [diff] [review]
Part 1: Add a nsContentUtils::IsNonSubresourceRequest helper

Please uplift to aurora. Part of service worker feature.
Attachment #8671713 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Ehsan, all the patches here or just Part 1?
Flags: needinfo?(ehsan)
(Assignee)

Comment 10

3 years ago
All.
Flags: needinfo?(ehsan)
I'm hitting merge conflicts trying to uplift these. Ehsan, can you post rebased patches (and fold in that followup, I suppose)?
Flags: needinfo?(ehsan)
(Assignee)

Comment 12

3 years ago
Let me uplift myself.  Thanks for trying!
Flags: needinfo?(ehsan)
backed out for bustage - https://treeherder.mozilla.org/logviewer.html#?job_id=1317527&repo=mozilla-aurora
Flags: needinfo?(ehsan)
(Assignee)

Comment 15

3 years ago
We decided to not ship SW in 43.
status-firefox43: fixed → wontfix
Flags: needinfo?(ehsan)
You need to log in before you can comment on or make changes to this bug.