1213150 - Some nsIInterceptedChannel cleanup

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[(no longer active)]

This doesn't need to block v1 but I'm nominating it for easier tracking of the uplifts.  I have some cleanup patches.

Comment 1

[(no longer active)]

Attachment: Part 1: Add a nsContentUtils::IsNonSubresourceRequest helper

Comment 2

[(no longer active)]

Attachment: Part 2: Rework ShouldPrepareForIntercept() in terms of subresource requests

Comment 3

[(no longer active)]

Attachment: Part 3: Remove nsIInterceptedChannel.isNavigation

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/402e89017708
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff1551e09f8f
https://hg.mozilla.org/integration/mozilla-inbound/rev/57541b82c71e

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d24051f4449

Comment 6

[(no longer active)]

Comment on attachment 8671713 [details] [diff] [review]
Part 1: Add a nsContentUtils::IsNonSubresourceRequest helper

These are cleanup patches that would be nice to backport to Aurora for easier uplift of service worker changes.  They should not affect anything but service workers.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/402e89017708
https://hg.mozilla.org/mozilla-central/rev/ff1551e09f8f
https://hg.mozilla.org/mozilla-central/rev/57541b82c71e
https://hg.mozilla.org/mozilla-central/rev/9d24051f4449

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8671713 [details] [diff] [review]
Part 1: Add a nsContentUtils::IsNonSubresourceRequest helper

Please uplift to aurora. Part of service worker feature.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Ehsan, all the patches here or just Part 1?

Comment 10

[(no longer active)]

All.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm hitting merge conflicts trying to uplift these. Ehsan, can you post rebased patches (and fold in that followup, I suppose)?

Comment 12

[(no longer active)]

Let me uplift myself.  Thanks for trying!

Comment 13

[(no longer active)]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/64af6c22c6b7
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/274255b2f25b
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/ac129c8e6dfb

Comment 14

[Carsten Book [:Tomcat]]

backed out for bustage - https://treeherder.mozilla.org/logviewer.html#?job_id=1317527&repo=mozilla-aurora

Comment 15

[(no longer active)]

We decided to not ship SW in 43.