Some nsIInterceptedChannel cleanup

RESOLVED FIXED in Firefox 44

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla44
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 wontfix, firefox44 fixed)

Details

Attachments

(3 attachments)

Assignee

Description

4 years ago
This doesn't need to block v1 but I'm nominating it for easier tracking of the uplifts.  I have some cleanup patches.
Status: NEW → ASSIGNED
Attachment #8671713 - Flags: review?(josh) → review+
Attachment #8671714 - Flags: review?(josh) → review+
Attachment #8671715 - Flags: review?(josh) → review+
Assignee

Comment 6

4 years ago
Comment on attachment 8671713 [details] [diff] [review]
Part 1: Add a nsContentUtils::IsNonSubresourceRequest helper

These are cleanup patches that would be nice to backport to Aurora for easier uplift of service worker changes.  They should not affect anything but service workers.
Attachment #8671713 - Flags: approval-mozilla-aurora?
Comment on attachment 8671713 [details] [diff] [review]
Part 1: Add a nsContentUtils::IsNonSubresourceRequest helper

Please uplift to aurora. Part of service worker feature.
Attachment #8671713 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Ehsan, all the patches here or just Part 1?
Flags: needinfo?(ehsan)
Assignee

Comment 10

4 years ago
All.
Flags: needinfo?(ehsan)
I'm hitting merge conflicts trying to uplift these. Ehsan, can you post rebased patches (and fold in that followup, I suppose)?
Flags: needinfo?(ehsan)
Assignee

Comment 12

4 years ago
Let me uplift myself.  Thanks for trying!
Flags: needinfo?(ehsan)
Assignee

Comment 15

4 years ago
We decided to not ship SW in 43.
Flags: needinfo?(ehsan)
You need to log in before you can comment on or make changes to this bug.