Closed Bug 1213161 Opened 4 years ago Closed 4 years ago

Really ignore build directories for js shell.

Categories

(Firefox :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: wuwei, Unassigned)

Details

Attachments

(1 file)

Trivial patch. Really ignore build directories for js shell in '.gitignore'.
Attachment #8671725 - Flags: review?(shu)
Comment on attachment 8671725 [details] [diff] [review]
0001-Really-ignore-build-directories-for-js-shell.patch

Review of attachment 8671725 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know what's going on here.
Attachment #8671725 - Flags: review?(shu) → review?(sphink)
Comment on attachment 8671725 [details] [diff] [review]
0001-Really-ignore-build-directories-for-js-shell.patch

Review of attachment 8671725 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. Or at least, looks better than what was there before.
Attachment #8671725 - Flags: review?(sphink) → review+
Attachment #8671725 - Flags: checkin?
(In reply to Shu-yu Guo [:shu] from comment #1)
> Comment on attachment 8671725 [details] [diff] [review]
> 0001-Really-ignore-build-directories-for-js-shell.patch
> 
> Review of attachment 8671725 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I don't know what's going on here.

My bad, sorry. I should explain this before asking for r? :-)
This patch is related to spidermonkey folder so I intuitively thought it should be reviewed by spidermonkey guys.

(In reply to Steve Fink [:sfink, :s:] from comment #2)
> Comment on attachment 8671725 [details] [diff] [review]
> 0001-Really-ignore-build-directories-for-js-shell.patch
> 
> Review of attachment 8671725 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> lgtm. Or at least, looks better than what was there before.

Thank you. :-)
(In reply to Wei Wu [:wuwei UTC+8] from comment #3)
> (In reply to Shu-yu Guo [:shu] from comment #1)
> > Comment on attachment 8671725 [details] [diff] [review]
> > 0001-Really-ignore-build-directories-for-js-shell.patch
> > 
> > Review of attachment 8671725 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > I don't know what's going on here.
> 
> My bad, sorry. I should explain this before asking for r? :-)
> This patch is related to spidermonkey folder so I intuitively thought it
> should be reviewed by spidermonkey guys.
> 

Oh, not your fault! I am just very clueless about VCS stuff.
https://hg.mozilla.org/mozilla-central/rev/738e0c645918
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Attachment #8671725 - Flags: checkin? → checkin+
You need to log in before you can comment on or make changes to this bug.