Closed
Bug 1213161
Opened 9 years ago
Closed 9 years ago
Really ignore build directories for js shell.
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: wuwei, Unassigned)
Details
Attachments
(1 file)
464 bytes,
patch
|
sfink
:
review+
cbook
:
checkin+
|
Details | Diff | Splinter Review |
Trivial patch. Really ignore build directories for js shell in '.gitignore'.
Reporter | ||
Updated•9 years ago
|
Attachment #8671725 -
Flags: review?(shu)
Comment 1•9 years ago
|
||
Comment on attachment 8671725 [details] [diff] [review] 0001-Really-ignore-build-directories-for-js-shell.patch Review of attachment 8671725 [details] [diff] [review]: ----------------------------------------------------------------- I don't know what's going on here.
Attachment #8671725 -
Flags: review?(shu) → review?(sphink)
Comment 2•9 years ago
|
||
Comment on attachment 8671725 [details] [diff] [review] 0001-Really-ignore-build-directories-for-js-shell.patch Review of attachment 8671725 [details] [diff] [review]: ----------------------------------------------------------------- lgtm. Or at least, looks better than what was there before.
Attachment #8671725 -
Flags: review?(sphink) → review+
Reporter | ||
Updated•9 years ago
|
Attachment #8671725 -
Flags: checkin?
Reporter | ||
Comment 3•9 years ago
|
||
(In reply to Shu-yu Guo [:shu] from comment #1) > Comment on attachment 8671725 [details] [diff] [review] > 0001-Really-ignore-build-directories-for-js-shell.patch > > Review of attachment 8671725 [details] [diff] [review]: > ----------------------------------------------------------------- > > I don't know what's going on here. My bad, sorry. I should explain this before asking for r? :-) This patch is related to spidermonkey folder so I intuitively thought it should be reviewed by spidermonkey guys. (In reply to Steve Fink [:sfink, :s:] from comment #2) > Comment on attachment 8671725 [details] [diff] [review] > 0001-Really-ignore-build-directories-for-js-shell.patch > > Review of attachment 8671725 [details] [diff] [review]: > ----------------------------------------------------------------- > > lgtm. Or at least, looks better than what was there before. Thank you. :-)
Comment 4•9 years ago
|
||
(In reply to Wei Wu [:wuwei UTC+8] from comment #3) > (In reply to Shu-yu Guo [:shu] from comment #1) > > Comment on attachment 8671725 [details] [diff] [review] > > 0001-Really-ignore-build-directories-for-js-shell.patch > > > > Review of attachment 8671725 [details] [diff] [review]: > > ----------------------------------------------------------------- > > > > I don't know what's going on here. > > My bad, sorry. I should explain this before asking for r? :-) > This patch is related to spidermonkey folder so I intuitively thought it > should be reviewed by spidermonkey guys. > Oh, not your fault! I am just very clueless about VCS stuff.
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/738e0c645918
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Updated•9 years ago
|
Attachment #8671725 -
Flags: checkin? → checkin+
You need to log in
before you can comment on or make changes to this bug.
Description
•