1213208 - Excessive spacing for account/folder selection submenus in context menu in Retina displays

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Andrew Janke]

Attachment: big-submenu-items.gif

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150929144111

Steps to reproduce:

On OS X 10.9 or 10.11:
Right-click on a message in the message list pane, select "Move To" or "Copy To" from the context menu, and then select one of the mail accounts.


Actual results:

Submenu items for mail accounts and for folders which contain subfolders – anything with a submenu under it – take up twice the vertical space as normal menu items. This takes up more screen real estate, and causes irregular menu item spacing in folders where the child items are a mix of folders which do and do not contain subfolders.


Expected results:

Menu item spacing should be the same as a normal menu item or submenu item, like the "Forward As", "Tag", and "Mark" items in the top context menu.

Comment 1

[Javi Rueda :javirid]

Unable to reproduce on OS X 10.11 and latest trunk.

Do you see the same problem with add-ons -e.g. themes- disabled, Andrew?

Comment 2

[Andrew Janke]

I don't have any Thunderbird add-ins installed. 

Still happening for me on Tb 42.0b1 on OS X 10.11.1 beta. Attaching a screenshot; note how the "B" folder and its parents take more vertical space than the leaf folders "A", C", etc.

Is there somewhere I can download a nightly build from the latest trunk to test out?

Comment 3

[Javi Rueda :javirid]

Mac builds should be on http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-central/, but lately there has not been any successfull build, so you would not find any there, only Linux and Windows ones.

But, if you are able to test -and willing to-, I am going to build my own copy of the repository and package the result in a .DMG so you could check it. It will install as Daily -the name they chose instead of Nightly.

I am packaging it now, I will post a new answer with the link so you can grab it.

Comment 4

[Andrew Janke]

Sure, I'll test off your build. I have an isolated system and set of accounts for testing, so I'm not paranoid about where the builds come from.

Comment 5

[Javi Rueda :javirid]

There you have it

https://drive.google.com/file/d/0B5O1vkTpesx6cXdNbXpiUnVSdmc

Comment 6

[Andrew Janke]

Attachment: Tb 42.0b1 on OS X 10.11.1 beta.png

Comment 7

[Andrew Janke]

Attachment: menus from Javi Rueda daily build

Javi: the extra spacing is still happening for me with that custom Daily build you posted. Looks just like the 42.0b1 for me.

You know what, this looks like a Retina display issue. All the shots so far have been from Retina MacBook Pros. I also tried it on an older non-Retina MacBook Pro, and the spacing issue does not happen there. (Attaching comparative screenshots.) The vertical alignment of text within the menu item cell looks off - too high, like what happened on Yosemite before the theme for that version was fully defined - but all the menu item cells are the same size.

Comment 8

[Andrew Janke]

Attachment: Tb 42.0b1 on non-Retina 10.11.0 beta.png

Comment 9

[Andrew Janke]

Or possibly it's a difference between OS X 10.11.0 and 10.11.1. The non-Retina MacBook has not been upgraded to 10.11.1 beta yet. When I find a few hours, I'll rebuild all my test boxes as 10.11 non-beta and separate 10.11.1 beta VMs, to remove that variable.

Comment 10

[Wayne Mery (:wsmwk)]

Still an issue with newer version?

Comment 11

[Richard Marti (:Paenglab)]

I'm seeing it too with Daily.

Comment 12

[Eckard Berberich]

I'm still seeing the issue with Daily in the "Recent" drop down menu (attachment)

Comment 13

[Eckard Berberich]

Attachment: "Recent" drop down menu

Comment 14

[Richard Marti (:Paenglab)]

Attachment: Mac-menu-arrow.patch

Philipp, you are one of the few Mac developers. Please could you check this patch?

I hope, you have a Retina Mac, then it's very obvious with the spacing. But also with a normal Mac you see the effect: Without patch, all menu arrows with the folder icons are slightly moved to the right compared to the normal ones like the "Recent" menu arrow. With patch they are correctly aligned.

Comment 15

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8954447 [details] [diff] [review]
Mac-menu-arrow.patch

Review of attachment 8954447 [details] [diff] [review]:
-----------------------------------------------------------------

I have a retina mac and this does seem to fix it for me, r=philipp

Comment 16

[Richard Marti (:Paenglab)]

Thanks.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a6f508bc1053
Define a image width/height for the folderMenuItem's menu arrow. r=philipp

Comment 18

[Richard Marti (:Paenglab)]

Comment on attachment 8954447 [details] [diff] [review]
Mac-menu-arrow.patch

This raised already pre 52 and ESR52 is supported until August. So it makes sense to fix this there too.

Comment 19

[Jorg K (CEST = GMT+2)]

I doubt that we're doing another TB 59 beta.

Comment 20

[Jorg K (CEST = GMT+2)]

Comment on attachment 8954447 [details] [diff] [review]
Mac-menu-arrow.patch

Already in TB 60 going to beta soon.

Comment 21

[Jorg K (CEST = GMT+2)]

TB 52.7 ESR:
https://hg.mozilla.org/releases/comm-esr52/rev/3e8c587bb542edaaa37693f28953812506c52c24