1213240 - JSONException caused by RecentTabsPanel$RecentTabsCursorLoader.loadCursor

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Clemens Eisserer]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151005144425
Firefox for Android

Steps to reproduce:

While my phone was connected to my PC for displaying the debug logs, I discovered the following exception while using FF 41 for Android:

10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser: JSON error
10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser: org.json.JSONException: Index 0 out of range [0..0)
10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser:     at org.json.JSONArray.get(JSONArray.java:282)
10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser:     at org.json.JSONArray.getJSONObject(JSONArray.java:510)
10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser:     at org.mozilla.gecko.SessionParser.parse(SessionParser.java:70)
10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser:     at org.mozilla.gecko.home.RecentTabsPanel$RecentTabsCursorLoader.loadCursor(RecentTabsPanel.java:319)
10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser:     at org.mozilla.gecko.home.SimpleCursorLoader.loadInBackground(SimpleCursorLoader.java:44)
10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser:     at org.mozilla.gecko.home.SimpleCursorLoader.loadInBackground(SimpleCursorLoader.java:26)
10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser:     at android.support.v4.content.AsyncTaskLoader$LoadTask.doInBackground$42af7916(Unknown Source)
10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser:     at android.support.v4.content.ModernAsyncTask$2.call(Unknown Source)
10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser:     at java.util.concurrent.FutureTask.run(FutureTask.java:237)
10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser:     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser:     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
10-09 12:52:13.104 4825-21263/? E/GeckoSessionParser:     at java.lang.Thread.run(Thread.java:841)


Actual results:

Exception


Expected results:

No Exception

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

This is touching org.mozilla.gecko.SessionParser.parse, vivek you were the last to touch the file. Any thoughts about this bug?

Comment 2

[Vivek Balakrishnan[:vivek]]

Attachment: MozReview Request: Bug 1213240 : Avoid parsing sessions json when empty r?bnicholson

Review commit: https://reviewboard.mozilla.org/r/29925/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29925/

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8705308 [details]
MozReview Request: Bug 1213240 : Avoid parsing sessions json when empty r?bnicholson

https://reviewboard.mozilla.org/r/29925/#review26751

Looks great!

Comment 4

[Vivek Balakrishnan[:vivek]]

https://hg.mozilla.org/integration/fx-team/rev/a54da7831cfcb3dfb2881573cb84cc058f62368b
Bug 1213240 : Avoid parsing sessions json when empty r=bnicholson

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a54da7831cfc