Closed Bug 1213244 Opened 9 years ago Closed 9 years ago

Hide browser chrome control panel drop down for 2.5.

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::Browser
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.5+)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.5+

People

(Reporter: mikehenrty, Assigned: mikehenrty)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

[gaia] mikehenrty:bug-1213244-remove-doorhanger > mozilla-b2g:master
46 bytes, text/x-github-pull-request
apastor
: review+
Details | Review
[gaia] mikehenrty:bug-1213244-reland-remove-doorhanger > mozilla-b2g:master
46 bytes, text/x-github-pull-request
mikehenrty
: review+
Details | Review 
In the reduced scope for 2.5, we are removing the browser chrome dropdown/doorhanger
Priority: -- → P2
Comment on attachment 8672619 [details] [review]
[gaia] mikehenrty:bug-1213244-remove-doorhanger > mozilla-b2g:master

This is a temporary measure until we re-enable the doorhanger, but with privacy information instead of pin the web. So for now I am not ripping out any code.
Attachment #8672619 - Flags: review?(apastor)
Comment on attachment 8672619 [details] [review]
[gaia] mikehenrty:bug-1213244-remove-doorhanger > mozilla-b2g:master

It seems that a Gij test is failing. It doesn't seem to be related, but can we rebase and rerun tests before landing? Thanks!
Attachment #8672619 - Flags: review?(apastor) → review+
master: https://github.com/mozilla-b2g/gaia/commit/6140a8431781f0457a7de9471ea1db56b7bcab4e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
whoops, had to revert. there is a failing test (Gij 11) which hadn't finished yet.

master: https://github.com/mozilla-b2g/gaia/commit/caec861abcd8f7107a585414ae7a508f9a909d14
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8673135 [details] [review]
[gaia] mikehenrty:bug-1213244-reland-remove-doorhanger > mozilla-b2g:master

Ok, green run [1]. r+ carries.

1.) https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=0e1acd7554e82452f9d1b408475f80464629536f
Attachment #8673135 - Flags: review+
master: https://github.com/mozilla-b2g/gaia/commit/a82d847dffea4cdc33b42a909faf4870e2cecbbe
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: