1213299 - Cancel download dialog should not use "ok"/"cancel" buttons

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Keunwoo Lee]

Attachment: tmp_15375-IMG_20151009_101330-1217358994.jpg

User Agent: Mozilla/5.0 (Android 5.1; Mobile; rv:41.0) Gecko/41.0 Firefox/41.0
Build ID: 20150917151118

Steps to reproduce:

1. Start a slow download.
2. Tap the pull down notification (not pause or cancel, but the main label).

Device is on Android 5.1.


Actual results:

A dialog pops up asking "Cancel download?" with two buttons, one labeled "Cancel" and the other labeled "Ok". It is not obvious whether the user should cancel the download by selecting "Cancel" or whether selecting "Cancel" continues downloading.


Expected results:

The button label text should be clearer, something like "Yes, cancel" and "No, continue download".

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

That's awkward. :) Thanks for filing.

Anthony, do you agree?

Comment 2

[Mohamed Hammoud]

Hi!

I'd like to work on this. I'm new to Firefox for Android (and open-source contributions) so I'm hoping to get started by working on this tweak. :)

Thanks.
Mohamed

Comment 3

[Mohamed Hammoud]

Hey,

I've just had a look through the code for the very first time! I've found DownloadNotifications.jsm; specifically ConfirmCancelPrompt which instantiates a confirm prompt from Services.prompt. Digging around some more, Services.jsm is a resource file which contains prompts... which points to NsIPromptService.

Looking through the docs here

https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIPromptService#confirm()

It doesn't appear there is a property available to change the text for OK/Cancel. Any ideas?

Thanks!

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

This seems like a dupe of bug 1156252. So, I'm just going to move the conversation there.

Comment 6

[swaroop.rao]

This seems to be a duplicate of a bug that is marked as RESOLVED. Will this defect also be closed or can I take it up? I've got a working build set up and ready to go.

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

No. Taping on the notification now takes you to the downloads list. The behavior does not exist as described in comment 0 so closing.