Closed
Bug 1213327
Opened 9 years ago
Closed 9 years ago
expose IAccessibleHyperlink on proxied accessibles
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
Details
Attachments
(3 files)
4.21 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
919 bytes,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
1.01 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
This is not a nice solution, however its basically the only option. We need to store the set of interfaces the proxy implementes, preferably without increasing the size of ProxyAccessibleWrap.
Attachment #8671960 -
Flags: review?(dbolter)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8671961 -
Flags: review?(dbolter)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8671962 -
Flags: review?(dbolter)
Updated•9 years ago
|
Attachment #8671960 -
Flags: review?(dbolter) → review+
Updated•9 years ago
|
Attachment #8671961 -
Flags: review?(dbolter) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8671962 [details] [diff] [review] expose iAccessibleHyperlink on proxied accessibles Review of attachment 8671962 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/windows/ia2/ia2AccessibleHyperlink.cpp @@ +28,5 @@ > if (IID_IAccessibleHyperlink == iid) { > + auto accWrap = static_cast<AccessibleWrap*>(this); > + if (accWrap->IsProxy() ? > + !(accWrap->ProxyInterfaces() & Interfaces::HYPERLINK) : > + !accWrap->IsLink()) A ternary operator as a condition eh? (I don't mind)
Attachment #8671962 -
Flags: review?(dbolter) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/99759cbeea5c https://hg.mozilla.org/integration/mozilla-inbound/rev/8be9e22dc7d8 https://hg.mozilla.org/integration/mozilla-inbound/rev/dba4e2f06001
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/99759cbeea5c https://hg.mozilla.org/mozilla-central/rev/8be9e22dc7d8 https://hg.mozilla.org/mozilla-central/rev/dba4e2f06001
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Updated•7 years ago
|
Assignee: nobody → tbsaunde+mozbugs
You need to log in
before you can comment on or make changes to this bug.
Description
•