Closed
Bug 1213365
Opened 9 years ago
Closed 9 years ago
Share environment update code between js and jit tests harnesses
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: terrence, Unassigned)
References
Details
Attachments
(1 file)
|
9.15 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
We do this rather differently in the different harnesses -- basically just cramming them in wherever. This patch makes things happen in a more structured manner. Note that we have to leave the manual futzing in run_tests as that is shared with multiprocessing's runner, which I don't trust to properly set up the environment, particularly with the tricks it has to play in windows.
Attachment #8672028 -
Flags: review?(sphink)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8672028 [details] [diff] [review] share_environment_update_code-v0.diff Review of attachment 8672028 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/tests/lib/tests.py @@ +71,5 @@ > + > + > +@contextmanager > +def change_env(env_overlay): > + # Apply the overlayed environment and record the current state. *overlaid
Attachment #8672028 -
Flags: review?(sphink) → review+
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fed3a2363a8a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•