1213420 - Allow a default build target for GMP and SystemAddons blobs

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[Dave Townsend [:mossop]]

Currently you have to include a definition in the JSON for every build target, system add-ons are likely to use the same add-on for all build targets so a "default" target needs to be supported.

Comment 1

[Dave Townsend [:mossop]]

Attachment: pull request

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Looks good, just a few nits on the pull request.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

There's a change freeze on Oct 21st, if you want to get this in before then.

Comment 4

[Dave Townsend [:mossop]]

I've updated the pull request with the changes from the review.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/3c08b79ac9ab3dd2b80956779129b1b9d5fdf3c5
Bug 1213420: Support a default build target entry for GMP and SystemAddons releases.

https://github.com/mozilla/balrog/commit/0cae344ce9e7be44af44b54e717bcaa5ed092355
Merge pull request #28 from Mossop/bug1213420

Bug 1213420: Support a default build target entry for GMP and SystemAddons releases.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8672099 [details] [review]
pull request

r+, merged, and deployed to dev. If you have some time to verify there we can get it deployed to prod.

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/3c08b79ac9ab3dd2b80956779129b1b9d5fdf3c5
Bug 1213420: Support a default build target entry for GMP and SystemAddons releases.

https://github.com/mozilla/balrog/commit/0cae344ce9e7be44af44b54e717bcaa5ed092355
Merge pull request #28 from Mossop/bug1213420

Comment 8

[Dave Townsend [:mossop]]

Looks good. Here are some example URLs:

https://aus4-dev.allizom.org/update/3/SystemAddons/32.0/20140728123855/LINUX/en-US/nightlytest/default/default/default/update.xml
https://aus4-dev.allizom.org/update/3/SystemAddons/32.0/20140728123855/OSX/en-US/nightlytest/default/default/default/update.xml
https://aus4-dev.allizom.org/update/3/SystemAddons/32.0/20140728123855/WINNT/en-US/nightlytest/default/default/default/update.xml

First two fall back to the default platform, last uses the WINNT specific platform entry.

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/3c08b79ac9ab3dd2b80956779129b1b9d5fdf3c5
Bug 1213420: Support a default build target entry for GMP and SystemAddons releases.

https://github.com/mozilla/balrog/commit/0cae344ce9e7be44af44b54e717bcaa5ed092355
Merge pull request #28 from Mossop/bug1213420

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/3c08b79ac9ab3dd2b80956779129b1b9d5fdf3c5
Bug 1213420: Support a default build target entry for GMP and SystemAddons releases.

https://github.com/mozilla/balrog/commit/0cae344ce9e7be44af44b54e717bcaa5ed092355
Merge pull request #28 from Mossop/bug1213420

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Great, I'll push this to prod Wednesday.

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

Deployed to production.