Closed Bug 1213430 Opened 9 years ago Closed 9 years ago

Add more Toast telemetry

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(firefox42 fixed, firefox43 fixed, firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox42 --- fixed
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

This patch adds some simple UI Telemetry to uses of ButtonToasts. I choose Event.SHOW since both cases were showing a tab or a home panel from the toast. We have used "reading_list" as an Extra in other places and we use "closetab" in the Tab Tray for undoing a close tab, so "switchtab" seemed to fit for this case.
Attachment #8672098 - Flags: review?(liuche)
Comment on attachment 8672098 [details] [diff] [review]
toast-telemetry v0.1

Review of attachment 8672098 [details] [diff] [review]:
-----------------------------------------------------------------

I also looked for a possible other entry point from Reader Mode, but it's the same one! :)
Attachment #8672098 - Flags: review?(liuche) → review+
Comment on attachment 8672098 [details] [diff] [review]
toast-telemetry v0.1

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Just collecting more telemetry
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Low risk, simple patches
[String/UUID change made/needed]: none
Attachment #8672098 - Flags: approval-mozilla-beta?
Attachment #8672098 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/100c16d60f76
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8672098 [details] [diff] [review]
toast-telemetry v0.1

Taking it as it should be low risk, should be in 42 beta 6.
Attachment #8672098 - Flags: approval-mozilla-beta?
Attachment #8672098 - Flags: approval-mozilla-beta+
Attachment #8672098 - Flags: approval-mozilla-aurora?
Attachment #8672098 - Flags: approval-mozilla-aurora+
Assignee: nobody → mark.finkle
I'm not seeing any telemetry in logcat when tapping on "Undo" toast button after closing a tab.
I'm not seeing any telemetry in logcat after switching tab after opening a link from a webpage, only for entries from "about:home" panels.
Does the patch should cover these cases?
Flags: needinfo?(mark.finkle)
(In reply to Mihai Pop from comment #8)
> I'm not seeing any telemetry in logcat when tapping on "Undo" toast button
> after closing a tab.
> I'm not seeing any telemetry in logcat after switching tab after opening a
> link from a webpage, only for entries from "about:home" panels.
> Does the patch should cover these cases?

The two cases you mention are code in JavaScript, and the Telemetry methods in JavaScript do not log to logcat. I don't think there is any way to see that data from the device. I do see the "closetab" telemetry on the dashboard:
http://people.mozilla.org/~mfinkle/uitelemetry/#events-tab

I need to run the scripts to see the other new toast probes.
Flags: needinfo?(mark.finkle)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: