1213436 - Reject core dumps with node IDs that don't fit in an IEEE 754 double

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Our IDs are derived from pointers (48 bits, which will fit) but some annoying person could purposely generate IDs that don't fit since we store them as unsigned 64 bit ints on disk / in protobuf.

Depends on bug 1211006 because we would like to use the JS::Value::isRepresentableNumber function defined in that patch.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Reject core dumps with node IDs that don't fit in an IEEE 754 double

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a6a481a3bf2

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8672126 [details] [diff] [review]
Reject core dumps with node IDs that don't fit in an IEEE 754 double

That try push went pretty poorly. Will fix this patch up before re-requesting review.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Looks like it is only 32 bit platforms that are getting caught in this assertion. Suspect my conversions are bad or something.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Reject core dumps with node IDs that don't fit in an IEEE 754 double

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Alright, the issue was that when we were doing uint64_t(ptr) the ptr was getting sign extended on 32 bit platforms. So now we do uint64_t(uintptr_t(ptr)) to avoid the sign extending.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0f68ff505f8

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Woops, that try push didn't include the patch for bug 1211006. New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c3f279c4ea3

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/888009041487

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/888009041487