1213464 - ImageBridgeChild and CompositorChild leak mTransport

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Andrew McCreight [:mccr8]]

~ImageBridgeParent does some boilerplate to destroy mTransport. ImageBridgeChild probably needs to do the same thing. Of course, this is all fairly academic at the moment because we leak ImageBridgeChild itself.

A similar issue likely exists for CompositorChild, or whatever the child process equivalent is of CrossProcessCompositorParent, if any.

Comment 1

[Andrew McCreight [:mccr8]]

I confirmed that this happens, and that putting the DeleteTask boilerplate in the dtor fixes the leak (in a hacked up version that runs the dtor).

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: ImageBridgeChild and CompositorChild should delete their Transport.

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8691581 [details] [diff] [review]
ImageBridgeChild and CompositorChild should delete their Transport.

Does this fix the remaining leaks you were seeing in bug 1227398? I hadn't bothered landing these because I thought it was somewhat questionable to land code that never runs (because these data structures both leak).

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8691581 [details] [diff] [review]
ImageBridgeChild and CompositorChild should delete their Transport.

Review of attachment 8691581 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good yes

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to Andrew McCreight [:mccr8] from comment #3)
> Does this fix the remaining leaks you were seeing in bug 1227398? I hadn't
> bothered landing these because I thought it was somewhat questionable to
> land code that never runs (because these data structures both leak).

It does fix the leaks, by the way. Thanks!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22812d820754

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/22812d820754