Combine DrawResults correctly in nsTablePainter

RESOLVED FIXED in Firefox 44

Status

()

Core
Layout: Images
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: seth, Assigned: seth)

Tracking

unspecified
mozilla44
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We're not correctly combining DrawResults in nsTablePainter. We need to prefer other failing DrawResults over BAD_IMAGE, as discussed in bug 1209715 and implemented for the DrawResult |operator&| overloads, but nsTablePainter is still using its own DrawResult combining code that doesn't do that. We can fix this by using the operator overloads.
(Assignee)

Comment 1

2 years ago
Created attachment 8672145 [details] [diff] [review]
Combine DrawResults correctly in nsTablePainter.

This actually simplifies the code! We don't need the local UpdateDrawResult()
function at all anymore.
Attachment #8672145 - Flags: review?(tnikkel)
Attachment #8672145 - Flags: review?(tnikkel) → review+
(Assignee)

Comment 3

2 years ago
Thanks for the review!
https://hg.mozilla.org/mozilla-central/rev/88c55feebfc4
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
(Assignee)

Updated

2 years ago
Blocks: 939645
You need to log in before you can comment on or make changes to this bug.