1213465 - Combine DrawResults correctly in nsTablePainter

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Seth Fowler [:seth] [:s2h]]

We're not correctly combining DrawResults in nsTablePainter. We need to prefer other failing DrawResults over BAD_IMAGE, as discussed in bug 1209715 and implemented for the DrawResult |operator&| overloads, but nsTablePainter is still using its own DrawResult combining code that doesn't do that. We can fix this by using the operator overloads.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Combine DrawResults correctly in nsTablePainter.

This actually simplifies the code! We don't need the local UpdateDrawResult()
function at all anymore.

Comment 2

[Seth Fowler [:seth] [:s2h]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=91fe811422dd

Comment 3

[Seth Fowler [:seth] [:s2h]]

Thanks for the review!

Comment 4

[Seth Fowler [:seth] [:s2h]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88c55feebfc4

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/88c55feebfc4