Open Bug 1213488 Opened 10 years ago Updated 3 years ago

Refactor GetUserMediaTask and MediaOperationTask in MediaManager

Categories

(Core :: WebRTC: Audio/Video, defect, P3)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox44 --- affected
Blocking Flags:
backlog webrtc/webaudio+

People

(Reporter: jib, Assigned: jib)

Details

Internally in MediaManager, there are two models for async operations w/callbacks. GetUserMediaTask [1] and MediaOperationTask [2] use the old way. Code is organized around runnables, and non-threadsafe JS callbacks are held off-main using nsRefPtr.forget() and nsRefPtr.swap() tricks. EnumerateDevicesImpl [3] is an example of the new way which avoids passing JS callbacks in the first place. [1] http://mxr.mozilla.org/mozilla-central/source/dom/media/MediaManager.cpp?rev=2499a66d5b37#1205 [2] http://mxr.mozilla.org/mozilla-central/source/dom/media/MediaManager.cpp?rev=2499a66d5b37#217 [3] http://mxr.mozilla.org/mozilla-central/source/dom/media/MediaManager.cpp?rev=2499a66d5b37#2287
backlog: --- → webrtc/webaudio+
Rank: 25
Priority: -- → P2
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.