Closed Bug 1213491 Opened 5 years ago Closed 5 years ago
Rendering Context2D::Context State::clips Pushed to an ns TArray
Over in bug 1201314 I'm making our static analysis recognize that C++ Standard Library containers may not be safe to memmove(). After whitelisting std::pair and std::atomic, the only remaining exception is CanvasRenderingContext2D::ContextState::clipsPushed, which is a std::vector and is stored in the nsAutoTArray CanvasRenderingContext2D::mStyleStack which can memmove it. std::vector isn't known to be a problem (yet), but it seems like a good idea to keep the analysis's whitelist small, and I understand that we usually prefer nsTArray anyway.
(In reply to Jed Davis [:jld] from comment #0) > std::vector isn't known to be a problem (yet) Update: it kind of is a problem, potentially; see bug 1201314 comment #18.
Attachment #8672168 - Flags: review?(nical.bugzilla) → review+
Thanks for the review. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3d58e0a649f (failures seem to be not mine)
You need to log in before you can comment on or make changes to this bug.