1213491 - Change CanvasRenderingContext2D::ContextState::clipsPushed to an nsTArray

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Over in bug 1201314 I'm making our static analysis recognize that C++ Standard Library containers may not be safe to memmove().  After whitelisting std::pair and std::atomic, the only remaining exception is CanvasRenderingContext2D::ContextState::clipsPushed, which is a std::vector and is stored in the nsAutoTArray CanvasRenderingContext2D::mStyleStack which can memmove it.

std::vector isn't known to be a problem (yet), but it seems like a good idea to keep the analysis's whitelist small, and I understand that we usually prefer nsTArray anyway.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Attachment: Patch

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

(In reply to Jed Davis [:jld] from comment #0)
> std::vector isn't known to be a problem (yet)

Update: it kind of is a problem, potentially; see bug 1201314 comment #18.

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Thanks for the review.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3d58e0a649f (failures seem to be not mine)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f09fa0610f9

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6f09fa0610f9