Closed Bug 1213552 Opened 6 years ago Closed 6 years ago

Differential Testing: Different output message involving lexicals

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: gkw, Unassigned)

References

Details

(Keywords: regression, testcase, Whiteboard: [fuzzblocker])

Attachments

(1 file)

this.x1 = '';
x1 += 'y';
 try {
     print(evalcx("let x1 = x1;", this));
 } catch (e) {}

$ ./js-dbg-64-dm-darwin-c00e93135684 --fuzzing-safe --no-threads --ion-eager testcase.js
undefined

$ ./js-dbg-64-dm-darwin-c00e93135684 --fuzzing-safe --no-threads --baseline-eager testcase.js
$

Tested this on m-c rev c00e93135684.

My configure flags are:

CC="clang -Qunused-arguments" CXX="clang++ -Qunused-arguments" AR=ar AUTOCONF=/usr/local/Cellar/autoconf213/2.13/bin/autoconf213 sh /Users/skywalker/trees/mozilla-central/js/src/configure --target=x86_64-apple-darwin12.5.0 --enable-debug --disable-threadsafe --enable-more-deterministic --with-ccache --enable-gczeal --enable-debug-symbols --disable-tests

python -u ~/funfuzz/js/compileShell.py -b "--enable-debug --enable-more-deterministic" -r c00e93135684

Due to skipped revisions, the first bad revision could be any of:
changeset:   https://hg.mozilla.org/mozilla-central/rev/3bcc3881b95d
user:        Shu-yu Guo
date:        Tue Oct 06 14:00:28 2015 -0700
summary:     Bug 589199 - Make a global lexical scope and hook it up to JS entry points. (r=efaust)

changeset:   https://hg.mozilla.org/mozilla-central/rev/b9f647fe2d10
user:        Shu-yu Guo
date:        Tue Oct 06 14:00:29 2015 -0700
summary:     Bug 589199 - Parse and emit bytecode for global lexicals. (r=efaust)

changeset:   https://hg.mozilla.org/mozilla-central/rev/b2d8f1cd3afc
user:        Shu-yu Guo
date:        Tue Oct 06 14:00:29 2015 -0700
summary:     Bug 589199 - Support global lexicals in the interpreter. (r=efaust)

changeset:   https://hg.mozilla.org/mozilla-central/rev/6e4a8943d496
user:        Shu-yu Guo
date:        Tue Oct 06 14:00:29 2015 -0700
summary:     Bug 589199 - Support global lexicals in Baseline. (r=jandem)

changeset:   https://hg.mozilla.org/mozilla-central/rev/26fc971a24c4
user:        Shu-yu Guo
date:        Tue Oct 06 14:00:29 2015 -0700
summary:     Bug 589199 - Support global lexicals in Ion. (r=jandem)

changeset:   https://hg.mozilla.org/mozilla-central/rev/3228ac384c92
user:        Shu-yu Guo
date:        Tue Oct 06 14:00:29 2015 -0700
summary:     Bug 589199 - Fix eval static scope to play with the global lexical scope. (r=efaust)

changeset:   https://hg.mozilla.org/mozilla-central/rev/04eb8f524122
user:        Shu-yu Guo
date:        Tue Oct 06 14:00:29 2015 -0700
summary:     Bug 589199 - Fix up the global lexical scope when merging off-thread compiled scripts. (r=bhackett)

changeset:   https://hg.mozilla.org/mozilla-central/rev/c609df6d3895
user:        Shu-yu Guo
date:        Tue Oct 06 14:00:29 2015 -0700
summary:     Bug 1202902 - Support non-syntactic extensible lexical scopes. (r=billm)

Shu-yu, is bug 589199 a likely regressor? (or bug 1202902, for that matter)
Flags: needinfo?(shu)
fwiw, this blocks finding other bugs on compareJIT. Is this just a bug limited to evalcx?
Whiteboard: [fuzzblocker]
Flags: needinfo?(shu)
Comment on attachment 8672772 [details] [diff] [review]
Fix typo in using TI to guard against introducing shadowing global lexical bindings.

Review of attachment 8672772 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops.
Attachment #8672772 - Flags: review?(efaustbmo) → review+
I think we should land a test for this.
Flags: needinfo?(shu)
https://hg.mozilla.org/mozilla-central/rev/88fa17cdbb62
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Flags: needinfo?(shu)
You need to log in before you can comment on or make changes to this bug.