Closed Bug 1213595 Opened 9 years ago Closed 9 years ago

Tweak .toolbarbutton-1 colors on Linux

Categories

(Firefox :: Theme, defect)

Unspecified
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

      No description provided.
Attached patch patchSplinter Review
Assignee: nobody → dao
Attachment #8672291 - Flags: review?(jaws)
Attachment #8672291 - Flags: review?(jaws) → review?(gijskruitbosch+bugs)
Comment on attachment 8672291 [details] [diff] [review]
patch

Dão, can you expand on what the motivation for (each of) the color changes here is? To work better with different background colors, or something?
Attachment #8672291 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8672291 [details] [diff] [review]
patch

This should look better on various backgrounds, different OS themes as well as lightweight themes. Most notably, the borders are currently opaque, which is rather suboptimal for a wide range of backgrounds.
Attachment #8672291 - Flags: review?(gijskruitbosch+bugs)
Attachment #8672291 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/b9f3e9bbb900
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: