1213647 - BrandName strings in "Manage Tones" are not picking translations when using unofficial branding

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[u547545]

Attachment: 2015-10-11-10-12-45.png

User Agent: Mozilla/5.0 (Windows NT 10.0; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150929144111

Steps to reproduce:

Prerequisite: set the phone in a language other than English.

1) Go to "Settings",
2) In the "Personalisation", click on "Sound",
3) In the "Tones", click "Manage Tones".


Actual results:

The headings "System Ringtones" and "System Alerts" are not fully translated. "System" is written in English, regardless of the language chosen initially.
Even finding with the titles of "default" ringtones.


Expected results:

The headings "Ringtones System" and "System Alerts" should be translated into the language of the phone. Same with "default" title ringtones.

-----------
Tested with ZTE Open C (FR).
Tested with several languages: French, Suomi, Deutsch, Spanish...
OS Version: 2.5.0.0-prerelease
Build Number: eng..20140806.064432
Platform Version: 44.0a1
Build Identifier: 20151011001632
Update Channel: nightly
Git Commit Info: 2015-10-10 21:44:14 (d6cc7ef0)

Comment 1

[Théo Chevalier]

Good catch!

Note that official builds are not affected ("System" and "Default" are replaced with "Firefox").


The strings are translated:
ringtoneBrandName = Default
ringtoneSectionBrandName = System

https://hg.mozilla.org/gaia-l10n/en-US/file/default/shared/branding/unofficial/branding.properties

The issue is that the App does not replace {{ringtoneBrandName}} and {{ringtoneSectionBrandName}} variables with those translations.

Just tried on 2.1, strings are translated as expected. 2.2 and 2.5 are affected.

Open C - 2.1 community builds # NOT AFFECTED #
Build ID               20150521184528
Gaia Revision          0d343f49c0e0a3928a4f456faf98e37bb26a6ef6
Gaia Date              2015-05-21 14:40:33

Open C - 2.2 community builds # AFFECTED #
Build ID               20150830202019
Gaia Revision          335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46
Gaia Date              2015-08-14 19:06:41

Comment 2

[Jim Porter (:squib)]

I don't think this is a ringtones-specific issue. The only recent changes to the app have been changes to *all* apps. This is probably better-suited to the L10N component.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1213647-fix-unofficial-branding > mozilla-b2g:master

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8674762 [details] [review]
[gaia] zbraniecki:1213647-fix-unofficial-branding > mozilla-b2g:master

So, seems like unofficial branding has been broken by me since Aug 2014 and nobody noticed. :)

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/d5fd1dafc09847eb43108eaf5819ad2817d86ca4

Comment 6

[u547545]

Verified

OS Version: 2.5.0.0-prerelease
Build Number: eng..20140806.064432
Platform Version: 44.0a1
Build Identifier: 2015101801931
Update Channel: nightly
Git Commit Info: 2015-10-17 (9651a251)