Closed
Bug 1213672
Opened 9 years ago
Closed 9 years ago
Forget button doesn't work anymore
Categories
(Toolkit :: Places, defect)
Tracking
()
VERIFIED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox43 | --- | unaffected |
firefox44 | --- | verified |
People
(Reporter: u428464, Assigned: Yoric)
References
Details
(Keywords: regression)
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0 Build ID: 20151010030234 Steps to reproduce: Click on the forget button. Actual results: Nightly opens a new window on top of current session. Expected results: Nightly clears expected history, all windows are closed and a new window is opened.
Component: Untriaged → Bookmarks & History
Version: 44 Branch → Trunk
Comment 1•9 years ago
|
||
The following error message is shown in Browser console when I click the forget button. A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'? See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise Date: Mon Oct 12 2015 00:22:38 GMT+0900 Full Message: ReferenceError: onWindowOpened is not defined Full Stack: Sanitizer.prototype.items.openWindows.clear<@chrome://browser/content/sanitize.js:690:9 TaskImpl_run@resource://gre/modules/Task.jsm:314:40 TaskImpl@resource://gre/modules/Task.jsm:275:3 createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14 Sanitizer.prototype._sanitize<@chrome://browser/content/sanitize.js:146:13 TaskImpl_run@resource://gre/modules/Task.jsm:314:40 TaskImpl@resource://gre/modules/Task.jsm:275:3 createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14 Sanitizer.prototype.sanitize<@chrome://browser/content/sanitize.js:85:19 TaskImpl_run@resource://gre/modules/Task.jsm:314:40 TaskImpl@resource://gre/modules/Task.jsm:275:3 createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14 .forgetButtonCalled@resource:///modules/CustomizableWidgets.jsm:1056:21 .handleEvent@resource:///modules/CustomizableWidgets.jsm:1072:11 EventListener.handleEvent*.onViewShowing@resource:///modules/CustomizableWidgets.jsm:1078:7 CustomizableUIInternal.wrapWidgetEventHandler/aWidget[aEventName]@resource:///modules/CustomizableUI.jsm:2368:16 showSubView@chrome://browser/content/customizableui/panelUI.xml:185:11 PanelUI.showSubView@chrome://browser/content/customizableui/panelUI.js:319:7 CustomizableUIInternal.handleWidgetCommand@resource:///modules/CustomizableUI.jsm:1464:7 EventListener.handleEvent*CustomizableUIInternal.buildWidget@resource:///modules/CustomizableUI.jsm:1339:7 WidgetGroupWrapper_forWindow@resource:///modules/CustomizableUI.jsm:3727:18 CustomizeMode.prototype.makePaletteItem@resource:///modules/CustomizeMode.jsm:785:22 CustomizeMode.prototype.populatePalette@resource:///modules/CustomizeMode.jsm:765:27 CustomizeMode.prototype.enter/<@resource:///modules/CustomizeMode.jsm:289:7 TaskImpl_run@resource://gre/modules/Task.jsm:330:41 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934:23 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7 Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:11 this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:776:7 this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:711:7 CustomizeMode.prototype.deferredWrapToolbarItem/<@resource:///modules/CustomizeMode.jsm:847:7 sanitize.js:690:0
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•9 years ago
|
status-firefox43:
--- → unaffected
status-firefox44:
--- → affected
Comment 2•9 years ago
|
||
Regression window: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=ef6f7c6a5a79f9ba818e128d9207dd6706e64de0&tochange=bbefa0967bad regressed by: Bug 1089695
Blocks: 1089695
Keywords: regression
Updated•9 years ago
|
Component: Bookmarks & History → Places
Product: Firefox → Toolkit
Version: Trunk → 44 Branch
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dteller
Assignee | ||
Comment 3•9 years ago
|
||
Bug 1213672 - Turning onWindowOpened into a variable;r?mak
Attachment #8672599 -
Flags: review?(mak77)
Comment 4•9 years ago
|
||
Comment on attachment 8672599 [details] MozReview Request: Bug 1213672 - Turning onWindowOpened into a variable;r?mak https://reviewboard.mozilla.org/r/21739/#review19601
Attachment #8672599 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=622bafcbf7db
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/466f3cc06a67
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Updated•8 years ago
|
Flags: qe-verify+
Comment 8•8 years ago
|
||
Reproduced the initial issue using old Nightly from 2015-10-11 on Windows 10 64bit, verified that using Firefox 44 beta 4 the issue is fixed across platforms (Windows 10 64-bit, Ubuntu 14.04 64-bit and Mac OS X 10.11.1).
You need to log in
before you can comment on or make changes to this bug.
Description
•