Closed
Bug 1213682
Opened 10 years ago
Closed 10 years ago
Send the correct aarch64 toolchain info to Gecko
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
FxOS-S10 (30Oct)
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | fixed |
People
(Reporter: afarden, Assigned: afarden)
References
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.101 Safari/537.36
|
Assignee | |
Comment 1•10 years ago
|
||
Gecko is going to need some serious massaging, but we can at least be sure Gonk is configuring the toolchain correctly.
Attachment #8672403 -
Flags: review?(lissyx+mozillians)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8672403 [details] [review]
Gonk PR
Looks good but I think we want to change the indendation. Michael, Juan, any feedback on this?
Attachment #8672403 -
Flags: review?(lissyx+mozillians)
Attachment #8672403 -
Flags: review+
Attachment #8672403 -
Flags: feedback?(mwu)
Attachment #8672403 -
Flags: feedback?(jgomez)
|
||
Updated•10 years ago
|
Attachment #8672403 -
Flags: feedback?(mwu) → feedback+
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8672403 [details] [review]
Gonk PR
it's ok.
Maybe for naming consistency I'd change $ARCH_ARM_FPU variable name to something more general: $ARCH_FPU (because x86 archs have FPUs as well).
Attachment #8672403 -
Flags: feedback?(jgomez) → feedback+
|
|
||
Updated•10 years ago
|
Assignee: nobody → adam
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
||
Comment 4•10 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
status-b2g-master:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S10 (30Oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•