1213738 - LambdaRunnable should move lambda instead of copying it

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P4)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

From Coverity:

** CID 1307876:  Performance inefficiencies  (PASS_BY_VALUE)
/obj-x86_64-unknown-linux-gnu/dist/include/mozilla/media/MediaUtils.h: 222 in mozilla::media::NewTaskFrom<mozilla::MediaManager::SelectSettings(mozilla::dom::MediaStreamConstraints &, nsRefPtr<mozilla::media::Refcountable<mozilla::ScopedDeletePtr<nsTArray<nsRefPtr<mozilla::MediaDevice>>>>> &)::[lambda() (instance 1)]>(T1)()


________________________________________________________________________________________________________
*** CID 1307876:  Performance inefficiencies  (PASS_BY_VALUE)
/obj-x86_64-unknown-linux-gnu/dist/include/mozilla/media/MediaUtils.h: 222 in mozilla::media::NewTaskFrom<mozilla::MediaManager::SelectSettings(mozilla::dom::MediaStreamConstraints &, nsRefPtr<mozilla::media::Refcountable<mozilla::ScopedDeletePtr<nsTArray<nsRefPtr<mozilla::MediaDevice>>>>> &)::[lambda() (instance 1)]>(T1)()
216       }
217       OnRunType mOnRun;
218     };
219     
220     template<typename OnRunType>
221     LambdaTask<OnRunType>*
   CID 1307876:  Performance inefficiencies  (PASS_BY_VALUE)
   Passing parameter aOnRun of type "mozilla::MediaManager::SelectSettings(mozilla::dom::MediaStreamConstraints &, nsRefPtr<mozilla::media::Refcountable<mozilla::ScopedDeletePtr<nsTArray<nsRefPtr<mozilla::MediaDevice> > > > > &)::[lambda() (instance 1)]" (size 936 bytes) by value.
222     NewTaskFrom(OnRunType aOnRun)
223     {
224       return new LambdaTask<OnRunType>(aOnRun);
225     }
226     
227     /* media::CoatCheck - There and back again. Park an object in exchange for an id.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1213738 - media::NewRunnableFrom() and media::NewTaskFrom() move lambda arg instead of copying it.

Bug 1213738 - media::NewRunnableFrom() and media::NewTaskFrom() move lambda arg instead of copying it.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8672852 [details]
MozReview Request: Bug 1213738 - media::NewRunnableFrom() and media::NewTaskFrom() move lambda arg instead of copying it.

https://reviewboard.mozilla.org/r/21801/#review19573

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

FYI the intermittent build-fail on OS X 10.7 debug seems to be on inbound.

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1213738 - media::Pledge.Then() moves lambda args instead of copying them.

Bug 1213738 - media::Pledge.Then() moves lambda args instead of copying them.

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I forgot I should update the other lambda-using function in that file as well.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8673251 [details]
MozReview Request: Bug 1213738 - media::Pledge.Then() moves lambda args instead of copying them.

https://reviewboard.mozilla.org/r/21873/#review19653

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://reviewboard.mozilla.org/r/21873/#review19655

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a781e1344f60
https://hg.mozilla.org/integration/mozilla-inbound/rev/1dfe9719da6c

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a781e1344f60
https://hg.mozilla.org/mozilla-central/rev/1dfe9719da6c